From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Fri, 5 Sep 2014 18:33:50 GMT Message-ID: <201409051833.s85IXo6a052924@git.osmocom.org> Subject: openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-637-gc91e035 Message: 7 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, jerlbeck/wip/gprs-patching has been updated discards 944ec35a33df46b44fca0fe6917e6b8f5c501744 (commit) discards 288b5e57e71ab7a0f00a82a042d4411a52892f9b (commit) discards 5dcd1fc2657f145e5e5f1f84c4df1e7e17b84622 (commit) discards f302ec0af9d4205a89ae88270dcc40c74e490c60 (commit) discards c5b52f5305179e4d3a96c994b32f4345ae1a1e57 (commit) discards d4e635709d45e43c877dbb148b91a0fc8d332bd5 (commit) discards 493ade8484933adb038f12f4b4845acb6e236878 (commit) discards 4d19de5c2f46ee20882c7d1870860a3b83e266bb (commit) discards 7e9b7b88969e2ece95cc3715ae0d5cb2240bd6fb (commit) discards adada39c756344565d687299bede230144aaceda (commit) discards b52f27d185f2e4f7556b2df4c424504efaf1d6d1 (commit) discards f74f1af1c78a86d16e2152cc756e0a31a159c1ef (commit) discards 02e2c168b8a71784d7b8bf20e942e432bec0770a (commit) discards 2ed6096e62ccf5435f9029335803d87ddfdefcd1 (commit) via c91e03505fbfd579e35e684ecfed3aa367297ac6 (commit) via 8960f3d38dd21f9496b7eddee366bd23659c5791 (commit) via 7fcaa4df94995b36119d53ed9134ffce1c72061e (commit) via fa99ac10279904b9c8c53a640811d64b06b1db9b (commit) via 7ce6a8928284bc2909de2e44a94840b3df870545 (commit) via fe35a31e968a5c2b53dbfb7c7ff0b04561714de7 (commit) via b156bd6499733650e2b051e6cc1a71f0bb2ab74e (commit) via dd497c6176dda347f63e02f79a8d8ecfe1bf1c7f (commit) via a9d30c09549b6dcb2b5a9326d2a2d64420b513ab (commit) via 74a3672d04684d9d927ffe49bf5fece82bace372 (commit) via 786d9c7a3ea4fc03266922d44ae95ae118379664 (commit) via 74a8fc0ceaa986de20df03a26b3dc24ff563a3cf (commit) via 400282f1214805ca8ea0b5e8886f4f47fcff64e2 (commit) via 1dd3216b5e27b61b667327339775c0e19d89d9bb (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (944ec35a33df46b44fca0fe6917e6b8f5c501744) \ N -- N -- N (c91e03505fbfd579e35e684ecfed3aa367297ac6) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=c91e03505fbfd579e35e684ecfed3aa367297ac6 commit c91e03505fbfd579e35e684ecfed3aa367297ac6 Author: Jacob Erlbeck Date: Fri Sep 5 14:32:36 2014 +0200 sgsn: Send detach(re-attach) instead of gmm status if TLLI unknown (TODO) The osmo-sgsn sends Status messages (or nothing in case of non GMM/GSM) when the TLLI is unknown. This prevents the MS from reconnecting. This experimental patch initiates a MT detach procedure to force a re-attach to set up a valid LLE context. TODO: - commit message - handle MO detach req (perhaps just send a faked ACK then) - test cases Note that the MS can be put into REGISTERED state after initially wanting to detach itself, since it will receive a Detach Req (re-attach). This same behaviour has been observed with another SGSN. Ticket: OW#???? Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=8960f3d38dd21f9496b7eddee366bd23659c5791 commit 8960f3d38dd21f9496b7eddee366bd23659c5791 Author: Jacob Erlbeck Date: Thu Sep 4 11:42:08 2014 +0200 gbproxy: Remove patch_mode, update initial checks This patch removes the patch_mode feature including the related VTY command patch-mode. Where sensible, the other configuration flags are queried instead. In addition, this initial checks in gbprox_process_bssgp_dl() and gbprox_process_bssgp_ul() have been updated. The patch mode feature has not been used and was increasingly difficult to maintain. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7fcaa4df94995b36119d53ed9134ffce1c72061e commit 7fcaa4df94995b36119d53ed9134ffce1c72061e Author: Jacob Erlbeck Date: Thu Sep 4 11:08:50 2014 +0200 gbproxy/test: Add assertions, improve test coverage This patch add explicit tests for - gbproxy_peer_by_bvci - gbproxy_peer_by_nsei - gbproxy_cleanup_peers - gbproxy_peer_by_rai - gbproxy_peer_by_lai - gbproxy_peer_by_lac and for messages with an unknown TLLI sent by the SGSN. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fa99ac10279904b9c8c53a640811d64b06b1db9b commit fa99ac10279904b9c8c53a640811d64b06b1db9b Author: Jacob Erlbeck Date: Wed Sep 3 11:59:48 2014 +0200 gbproxy: Reset IMSI acquisition and free stored messages in tlli_info Currently the stored messages are only removed, when IMSI acquisition has succeeded. In addition, receiving two ATTACH_REQ messages in sequence (e.g. due to loss of a Identity Req/Resp message) will not restart the IMSI acquisition procedure. This patch adds gbproxy_tlli_info_discard_messages() to clean up the message list and calls it from gbproxy_delete_tlli() fixing a potential memory leak. It is also called when an Attach Request message has been received. In that case the imsi_acq_pending flag is cleared, too. This would (re-)trigger the IMSI acquisition procedure at each of these messages. If an Ident Response has been lost, resending the Ident Request with the same N(U) will not work. Therefore the N(U) gets incremented on each Ident Request generated by the gbproxy. The first N(U) used is 256 which shouldn't collide with the V(UT) used by the SGSN given that P-TMSI patching is enabled (since a new random TLLI is used initially on every new (no tlli_info) connection and V(U) starts with zero then). Ticket: OW#1261 Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=7ce6a8928284bc2909de2e44a94840b3df870545 commit 7ce6a8928284bc2909de2e44a94840b3df870545 Author: Jacob Erlbeck Date: Tue Sep 2 14:40:11 2014 +0200 gbproxy/test: Add test cases for IMSI acquisition If the Attach Request procedure gets restarted e.g. because of a lost message, all of these messages are stored if IMSI acquisition is in progress. This patch adds a test for this case and modifies the dump_peers function to output the number of stored messages. Note that the number of stored messages currently increases with each of the messages mentioned above which is not the desired behaviour. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=fe35a31e968a5c2b53dbfb7c7ff0b04561714de7 commit fe35a31e968a5c2b53dbfb7c7ff0b04561714de7 Author: Jacob Erlbeck Date: Thu Sep 4 14:53:30 2014 +0200 gbproxy: Fix P-TMSI reassignment Currently, a new P-TMSI within an Attach Accept or within an RA Update Request is applied to the TLLI mapping (gbproxy_reassign_tlli) _before_ patching is done. This can lead to inconsistent behaviour when the TLLI validation has not been completed, which is the case when subsequent RA UDP REQ are received. The new TLLI must not be applied to the message itself yet, it should only be considered for following messages. This patch moves the TLLI reassignment to gbproxy_update_tlli_state_after() to fix that. It also separates the implementation of the feature, that a new tlli_info can be created when such a message is received from the SGSN. This makes sense, when P-TMSI patching is not active and the tlli_info entry has expired. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=b156bd6499733650e2b051e6cc1a71f0bb2ab74e commit b156bd6499733650e2b051e6cc1a71f0bb2ab74e Author: Jacob Erlbeck Date: Fri Sep 5 10:22:27 2014 +0200 gbproxy: Change creation of tlli_info for SGSN originated messages Currently tlli_info are created for SGSN originated messages when the SGSN TLLI cannot be found and P-TMSI patching is active. This doesn't make much sense, since the BSS side TLLI is not known in this case. Given that the SGSN is working properly, that can only happen if either the tlli_info has expired or the gbproxy has been restarted. This patch disables tlli_info creation in this case . Note that these messages are passed unmodified to the MS so far. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=dd497c6176dda347f63e02f79a8d8ecfe1bf1c7f commit dd497c6176dda347f63e02f79a8d8ecfe1bf1c7f Author: Jacob Erlbeck Date: Thu Sep 4 13:45:56 2014 +0200 gbproxy/test: Extend P-TMSI patch test by a sequence of RA UDP REQ This adds a sequence of two RA update procedures to test_gbproxy_ptmsi_patching(). Each of them assigns a new P-TMSI. Note that the implementation fails to patch the RAI within the second message and does not fully verify the 3rd P-TMSI on reception of the SUSPEND ACK. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=a9d30c09549b6dcb2b5a9326d2a2d64420b513ab commit a9d30c09549b6dcb2b5a9326d2a2d64420b513ab Author: Jacob Erlbeck Date: Tue Sep 2 13:57:19 2014 +0200 gbproxy: Reorganize VTY commands Since the secondary SGSN selection and APN patching can both be enable/disabled by IMSI matching, this patch introduces a separate match-imsi command and removes the corresponding variant of the core-access-point-name command. P-TMSI patching and IMSI acquisition are will be enabled/disabled by match-imsi resp. secondary-sgsn. The patch-ptmsi and acquire-imsi commands are still available but are subject to being removed. The gbproxy_check_tlli() function is modified to use a tlli_info pointer instead of a numeric TLLI to test, whether patching is allowed. It is now used instead of accessing tlli_info->enable_patching directly. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=74a3672d04684d9d927ffe49bf5fece82bace372 commit 74a3672d04684d9d927ffe49bf5fece82bace372 Author: Jacob Erlbeck Date: Tue Sep 2 14:09:01 2014 +0200 gbproxy: Show number of stored messages in VTY show This patch extends the 'show gbproxy tllis' command to display the number of stored messages per tlli_info if there are any. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=786d9c7a3ea4fc03266922d44ae95ae118379664 commit 786d9c7a3ea4fc03266922d44ae95ae118379664 Author: Jacob Erlbeck Date: Fri Aug 29 13:32:17 2014 +0200 gbproxy: Forward SGSN originated STATUS messages with BVCI Currently all STATUS messages coming from the SGSN are just logged and dropped. This prevents the PCU from recognising that the (secondary) SGSN doesn't know about a certain BVCI and might require a reset procedure. This patch changes gbprox_rx_sig_from_bss() to forward STATUS messages with cause "Invalid BVCI" containing a BVCI to the BSS. Note that this will not forward broken "Invalid BVCI" messages which do not include a BVCI IE. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=74a8fc0ceaa986de20df03a26b3dc24ff563a3cf commit 74a8fc0ceaa986de20df03a26b3dc24ff563a3cf Author: Jacob Erlbeck Date: Fri Aug 29 12:20:15 2014 +0200 gbproxy: Make STATUS messages spec compliant Currently the gbproxy sends STATUS messages that are not compliant to GSM 08.18, 10.4.14.1: The BVCI must be included if (and only if) the cause is either "BVCI blocked" or "BVCI unknown". This patch adds a missing BVCI to UNKNOWN_BVCI and BVCI_BLOCKED status messages if the BVCI is available. Otherwise, INV_MAND_INF is used instead. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=400282f1214805ca8ea0b5e8886f4f47fcff64e2 commit 400282f1214805ca8ea0b5e8886f4f47fcff64e2 Author: Jacob Erlbeck Date: Thu Aug 28 13:49:13 2014 +0200 gbproxy: Fix parse_ctx->tlli update Only update parse_ctx->tlli when the TLLI has been patched if sent towards the BSS, so that this field always refers to the the BSS namespace. This fixes the APN patching that doesn't work currently when P-TMSI patching is enabled. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=1dd3216b5e27b61b667327339775c0e19d89d9bb commit 1dd3216b5e27b61b667327339775c0e19d89d9bb Author: Jacob Erlbeck Date: Fri Sep 5 18:08:12 2014 +0200 gbproxy/test: Check APN patching while P-TMSI patching is enabled This commit adds a single ACT PDP CTX REQ message to test_gbproxy_ptmsi_patching() to check whether APN patching works in this case, too. Note that this doesn't work currently, the APN patch count is not incremented. Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)