From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Sun, 03 Jun 2012 16:57:19 +0200 Message-ID: Subject: branch master updated. 0.4.2-2-g8b0d5b3 Message: 2 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "An utility library for Open Source Mobile Communications". The branch, master has been updated via 8b0d5b3726da5f35751d14a6c2238af2851e3a19 (commit) from 98d77bd4dcef86cb0a56bc0a5162bc407fb566d3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/libosmocore/commit/?id=8b0d5b3726da5f35751d14a6c2238af2851e3a19 commit 8b0d5b3726da5f35751d14a6c2238af2851e3a19 Author: Harald Welte Date: Sun Jun 3 12:41:24 2012 +0200 VTY: safe version of printing VTY welcome message The old method used raw writes to the telnet FD, which is bad for several reasons: a) we don't know if we can actually write that many bytes to the socket at the given time b) the socket is still in blocking mode, so we could stall the entire process c) there may be weird interaction with the buffered writes of the vty_out Now, the print_welcome() functionality has moved to vty_hello() instead, where we can use normal vty_out() in buffered mode. This commit is expected to fix the garbled welcome message on arm-eglibc targets. It might still be a good idea to migrate the entire telnet interface to libtelnet - but at some later time ;) ----------------------------------------------------------------------- Summary of changes: src/vty/telnet_interface.c | 19 ------------------- src/vty/vty.c | 11 +++++++++++ 2 files changed, 11 insertions(+), 19 deletions(-) hooks/post-receive -- An utility library for Open Source Mobile Communications