From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Wed, 30 Oct 2013 14:55:10 GMT Message-ID: <201310301455.r9UEtACH008883@git.osmocom.org> Subject: osmo-pcu.git branch zecke/features/clean-up updated. 0.2-167-g066e6f5 Message: 4 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, zecke/features/clean-up has been updated discards d3be1d922b6ff157594564bf7c699fed8fb48170 (commit) discards 50602597a5c1ef6743fea0235b0116845ec9b795 (commit) discards 51c028503e2bda70a8d8d7434cb56cfe19062e7b (commit) discards 1b87625e653a4fa4dec43237d7b13d5ff5bfbda0 (commit) discards 0f16d42bb81bdd4258d404999c46735af48a3dc1 (commit) discards 0545984e6475994c662ea600fff0b746d4dd096d (commit) discards 1441faa2b2e3d70d91ca8679bc1ccab0bee31901 (commit) discards ac6cd8d2df2ac3dfece3cf9445c0a5c25ad03805 (commit) discards 7046946865fe336ca998de0ef3c168ba5e1c9e13 (commit) discards 75451414967be6a0d28a18cda45cdb1d8063f8b3 (commit) discards 99059ce83201f50f28a1d96e5251ded0d9ce50f8 (commit) discards ee88a32edda2e5f108529c6d45e998cd04a3b93e (commit) discards 041bdae1f0931e2a320782296f09f0b364508859 (commit) discards 56d6641f65395541659d9fcaa80efa6d48e9ab63 (commit) discards ecd45705e83b71a841ecc9bcda54a362675b7e1a (commit) discards 979e257798dc47468e59694e8998b1c8afe2b5fe (commit) discards f1b58db7987442dd3ec13bb70777fb27109ae1ca (commit) discards 113dea90db872c961e03735f7421b51facaf74e0 (commit) discards 50b99f1eecb87a5b1e3cd1fa337e5b70b9326826 (commit) discards 592272adcabf0146d029d27ccd5518fa5baa60c9 (commit) discards 73d4cf8b06cc4418f130f7ce628d52c6cfdc6888 (commit) discards e59629914dc7ea9b3d0cd2a3ba4cfa13a170c0b7 (commit) discards 1755c83b953e3647e9cd95e105934e4c657e912a (commit) discards 2aa62963552fd8190309226d43d0af5288e0f8ca (commit) discards 31e006e232ab5f940aa9e78d4bf45da9397e8a30 (commit) discards 2a47a95a113b596893342eeadeb4133a480c3c4f (commit) discards 743392cd93d0f2f31e9d63478ccc315191f9a40b (commit) discards 2de686531a8da90fc0b4955af116f377cbad8b29 (commit) discards 83a80dc8f654f06304b1a378ac4fc20071a4012b (commit) discards 4b320a8c7a7cf6aaafb1c8687b9c1bd5acbe4739 (commit) discards dc3f4b2dc2d30560839c82da9d1e85de82872984 (commit) discards 92b04ee6df50680c4abca748c74740c07263e8f6 (commit) discards 7bb8a34cf07858b1207ccefec373867308c75a34 (commit) discards 5f4222db4fa1617aa1ca25de74a10bdf5b6eeb73 (commit) discards f49d51c3c9aea835afb1b6e20737b3baa92be21b (commit) discards 7e064d3143371f215985b11177faa2a33e601423 (commit) discards ac9b175aa01bfddb29f39ea5dffafe1c7aa4c384 (commit) discards 3b451fe4137d1fd771d32d6c3b155f2b713e0f99 (commit) discards b8ba632f7f4ece044920486d6298b5d6af8ff2c0 (commit) discards b9ccb81811233476da7eb0c5b38b7359190ecb2f (commit) discards 8444ee7ad744149549e0b19f14af061231263970 (commit) discards 8b8db57ce69d957acee20655ed9c443290fcf8d0 (commit) discards 07e1838ff2f66b35e4b069958d860043b9513809 (commit) discards f5b48b1cae2aa9a9dd7bf59d26cffcf0130208fc (commit) discards 1c658601d9851cf5b6b5cc88f0f6cc410f537862 (commit) discards f619f4c3ff9113f85b3a10a9dc92ccff5a1c4e5c (commit) discards b92f67b3bf934d4425cd6b73b1df684393a4387b (commit) discards d519bc59b770b12f2fe8c46a1642f5a98cd7bcc8 (commit) discards a5d3451074c08d46800e93dc31ae043bac780a5e (commit) discards 7d8170e3b3c2923f8ba8d8a4240ad2e4983fa995 (commit) discards 452812ada38c3e2efd9e3f09ba2d16709f5dca0f (commit) discards 7ac412cdf0cba9ddda7aa086586fc176e4ed0832 (commit) discards ed89a313847e97d39ef41527fa0f79135a47758f (commit) discards e71951c76d449955780277b1cdfd6cd6811fb275 (commit) discards 20f7ecf340eac37d13d26a96bd4bf3045d3ae8eb (commit) discards 63bf953a48f65c8d6911c7ec9f79d4d3965263bd (commit) discards c7069c97872ca6a210871b9289a003b8874b15ae (commit) discards bce8ee213c5005ad2bfbc2d838c1e3fa53d53888 (commit) discards d89e60abd57108ca87fe7865eea09e2009989752 (commit) discards e0f52357247a5336f70a3a7c3c62521916242d33 (commit) discards f67a37801bfac3b4b44b5904f4851f4f2ad5580d (commit) discards 44d78155037e220e6bddc7e6cff6b1abb01dc0f3 (commit) discards 0ff380dc802f0f142c1a0a29b90d1cdaad246d4f (commit) discards 02a68f1b820645f1cda0b8a6b67dcb42168ae825 (commit) discards 344778cc987a0f63506dddcad35b6634ee7e27ed (commit) discards 9b0115d95a5cd45e0576e10b95e6e39e4e976019 (commit) discards 6c1d3604762ecd8bbf3673c4aa72d5646ef254ba (commit) discards ba6a370cf549f624d7412c0730d960e5eb6d676c (commit) discards 286ad7f1d5cf9d05ed1020746c1b9717ec388c95 (commit) discards 15547fbd424210055d175c2f6d160dd46118d371 (commit) discards d606bb991dc2e8812cb6d9298115b7325447b146 (commit) discards 93b919aff7b6ea34d92e322daaf8e10eb28e9917 (commit) discards 6ad8a5090e54b0b2d62e8f5233cf38d608404012 (commit) discards fd751f114d2f2b6dcdf7f3270eff473b83e72b47 (commit) discards 47f129a785892a394f64bc45226bc44eee38bb4f (commit) discards 978d717f16b6128f662ab49b530ed416eb643d48 (commit) via 066e6f503cda5cc320b2efda9dbce6523eaf05cd (commit) via 35d3897b26cf5d47f9337722ee3cbf4279e7a33c (commit) via 3b39389e8da267849f59abeeaa91773571ad5706 (commit) via 5d3b6a03685f24c80d4959af0173bad2663ec88d (commit) via b09bca9f679363f5e56f10a1d528a225c4002e5d (commit) via 0aedc7229f495f610eacd3459af57639a6531198 (commit) via f1a75d9b14a8ab103c8ce9fd36b0f8cde9102cab (commit) via efa0cf20036305125f285cb1bea2a6fc33bf1508 (commit) via 0a02a944d0932ae293446aa6567bc602e2106679 (commit) via f8bbd1cddd16c73b6cec1d3f6fc111f079aa81e0 (commit) via 7f1aea0636712b79c4240f7723574ce56de801b8 (commit) via 02d9c90290017a78d5bdb7bcbc12a17cc80f21d9 (commit) via 82bdca6378900e48c37a27c76bcf4eb9f53cb3d3 (commit) via aeeac349229bd1bd0a02fad384ccdfe5c092c0ed (commit) via 1bb89acdcc20086c495d82a8d272696086abb13a (commit) via 72005c6726d7b39a65ac6bdb3850599e28be2b88 (commit) via 15294366b1aa64fc6649585d7dc9a94fb89d0dcc (commit) via e763594e57453b70274e7ff114af12e42b3a4242 (commit) via 429a710441f7e078b49351eb203066da7e2bc915 (commit) via e0a450eae5fb9a8be26bd2edc2026d7cc8391ffa (commit) via c83fd500428040538f05ebcbb85cf43a36816722 (commit) via 07f469c93f22fe41a00b7a9711f9050d1f4431b6 (commit) via c9b31b92617c24e67970050a43881f9610feba91 (commit) via 9c82fa6d37fa90b5ba15284ce391996740e4a65e (commit) via 6e7e95c5d2d65bc89a1c21b0ade182977180a4a9 (commit) via e2e83a8955a0cf2ab5368f06d86204e7a839bb22 (commit) via 7cc3aa3893e41b6c76b3ef39b6bfe528c5539ed2 (commit) via a948795f1daa898f345279c91b94a8d335edf38d (commit) via 8bc2afce7d722b106fa2a65869bb4a2721fbd056 (commit) via c9401a36c1f4044f42ed0b6c661bc65d74014af7 (commit) via 107e7728a21708ec70dbf9ceabd7c3cb5c5f3a67 (commit) via f39db9fc87a0944104e63ff49d31b80d4dd73a53 (commit) via cc711d0b7bfa6a9b133c04a7925ca62667c4ef72 (commit) via c1058fc85ee07321a80b1ddb91c8af8b183e4f12 (commit) via 16d7a115d1af6f845254c526f4de28e2ffa5199f (commit) via 8d26433a04e40fa3d5a1ff3df0bb6168f96ca8e4 (commit) via fa96209ed1ad628c55e45707180b7106252f5697 (commit) via 9fa714f1be53603486879dc738cc74fc22956776 (commit) via 965db4438724e7ce248fa4e6346ff1955508eca0 (commit) via c95e9d210130e50da1a5766592f88536e977bc56 (commit) via c9d6f2b3da04452810033d7dae6fb8e81dc046c2 (commit) via af06982d79d3d64ed354b2715ab41e5e04ccbe71 (commit) via 4e1c43d5994670efdbd7d9eb6e241c646d62c1ca (commit) via f1f8fb4405149ccdfb7879b317eab00d173608e0 (commit) via 054c6b2a0833742b3bd9c6abb996ca5a4c6b1d64 (commit) via 1b9749747e6fc749280223464698842e1ecb0170 (commit) via 332e4ccdebbcbf771d28d4020f82063ef6b28b54 (commit) via f21b39841992be54dbd4b52ff4318fe92ffed3bd (commit) via d746dc93bba4aa12aa54af203fbdd764e590e9d4 (commit) via 2f381d671ab82f0157a2a0a5c4b538d9fba2bbdc (commit) via 61c50fcfe9fa4ba59f9d5a4d41761ff67fe71262 (commit) via 010f4d914735c94a8088592525c290356e6dc9b7 (commit) via fa1c53cf044a71b66c6b6195cae9db85649a90be (commit) via 04aad882a0b74a63e42be7cd48eed676803ab5fd (commit) via 017fe6f52dee157f3a0c62b7d6492d6a989733ee (commit) via 38168955f3e139489cf664bc9870bb58939a9bc6 (commit) via 0367f247f953e0c7878b2ede47701dbf08d6dd65 (commit) via 8fb190fa212264f9a1f903f858ab3bfb68c3c736 (commit) via 90c99b1836d05cffad91db7b7078e88eb1ec8188 (commit) via 84203dac1ecd37c8d4ed6decbf041e2c709b42f7 (commit) via 7b6f641e42f5e71116a7cc0b1ee6c44d9577b678 (commit) via 6f9541c1048248d223790a448da64a0a6558a2f4 (commit) via abdb35a7dc9d2b7032718f16cb3c2bcbce4d705c (commit) via 92bc1d6cbfec1f08088564fd4fdb0f19b6b7041f (commit) via 9f8f13ad196be7ae0cf5526503e985766e7f6925 (commit) via 177f04e486c07b0fd2ae3f14b92a5b72c1e4a259 (commit) via 66ae33cce7221ca68d9c59040b665877d983c7c5 (commit) via 50457867b50f4651875c83b95023b390c62f7c12 (commit) via 0e83a081fdd1847ece2d8f453892507724b60f5b (commit) via f74ccd033c89078ca79afa8fe56760b0720dba49 (commit) via 74065216b73d654e16b87c6795234e1ff777e98d (commit) via 7e6942d126571ce735fcb8a61d417cbe602d7547 (commit) via 7c406b85166f56e5390e9b36a339f4350e93dc2c (commit) via c7b04c46a674ee79b24df99c0e21c9cb4fe56eae (commit) via 8bee1ec44efaf4e887ef65be539249aecea5245b (commit) via c1cd4864861c77e24d34cb25aeeeaa3a36aa65a0 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (d3be1d922b6ff157594564bf7c699fed8fb48170) \ N -- N -- N (066e6f503cda5cc320b2efda9dbce6523eaf05cd) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=066e6f503cda5cc320b2efda9dbce6523eaf05cd commit 066e6f503cda5cc320b2efda9dbce6523eaf05cd Author: Holger Hans Peter Freyther Date: Wed Oct 30 14:50:17 2013 +0100 tbf: Learn and propagate the TLLI changes due a new P-TMSI During a routing area update a new P-TMSI was assigned. During the PACKET CONTROL ACK on the DL we notice the change of TLLI but didn't propagate this. This means that a Routing Area Update Complete was only sent after a new RACH request. Addresses: <0007> gprs_rlcmac_meas.cpp:103 UL RSSI of TLLI=0x88661bc6: -67 dBm <0002> bts.cpp:945 Got ACK, but UL TBF is gone TLLI=0xe512eba3 <0007> gprs_rlcmac_meas.cpp:158 DL packet loss of IMSI=274080000004765 / TLLI=0xe512eba3: 0% <0002> tbf.cpp:668 TBF TFI=0 TLLI=0x88661bc6 T3169 timeout during transsmission <0002> tbf.cpp:690 - Assignment was on PACCH <0002> tbf.cpp:694 - No uplink data received yet http://cgit.osmocom.org/osmo-pcu/commit/?id=35d3897b26cf5d47f9337722ee3cbf4279e7a33c commit 35d3897b26cf5d47f9337722ee3cbf4279e7a33c Author: Holger Hans Peter Freyther Date: Sun Oct 27 20:57:35 2013 +0100 tbf: Have one imsi field and assign it through a function Have one IMSI field per TBF and assign through a function call. The IMSI should be used to look-up the TBF on the SGSN->PCU direction. http://cgit.osmocom.org/osmo-pcu/commit/?id=3b39389e8da267849f59abeeaa91773571ad5706 commit 3b39389e8da267849f59abeeaa91773571ad5706 Author: Holger Hans Peter Freyther Date: Sun Oct 27 20:31:47 2013 +0100 tbf: Make tfi private and update the code All logging code that used tbf->tfi is now using tbf_name to print the the TBF. External code is now using tfi() which is inlined and should result in the same code being generated as before (+debug code that can be stripped). http://cgit.osmocom.org/osmo-pcu/commit/?id=5d3b6a03685f24c80d4959af0173bad2663ec88d commit 5d3b6a03685f24c80d4959af0173bad2663ec88d Author: Holger Hans Peter Freyther Date: Sun Oct 27 17:01:14 2013 +0100 tbf: Make the tlli "private" and update the updating code Now all updates to the tlli/tlli_valid are in one place. If we implement the policy to update the matching/linked TBF we can now to do it in a single place. Add a todo item for that as I am waiting for feedback from the mailinglist. http://cgit.osmocom.org/osmo-pcu/commit/?id=b09bca9f679363f5e56f10a1d528a225c4002e5d commit b09bca9f679363f5e56f10a1d528a225c4002e5d Author: Holger Hans Peter Freyther Date: Sun Oct 27 16:39:36 2013 +0100 tbf: Create tbf_name and use it in log statements This is like gsm_lchan_name and should be used in log statements. This way we can easily change the information that is printed and we know how to search things. The other part is that direct use of tfi/tlli is removed which will allow us to make them private and at the same time start to resolve the "tlli" updated in many places. Not old log statements are changed yet. This will done whenever a bad log statement is seen on the console... http://cgit.osmocom.org/osmo-pcu/commit/?id=0aedc7229f495f610eacd3459af57639a6531198 commit 0aedc7229f495f610eacd3459af57639a6531198 Author: Holger Hans Peter Freyther Date: Sun Oct 27 15:59:40 2013 +0100 tbf: TODO:Mark TLLI changes as todo item in the code The TLLI can change when a new P-TMSI is assigned to the phone, e.g. during a (periodic) routing area update. When the TLLI changes we need to update all TBFs and maybe even register the timing advance for the new TLLI.. http://cgit.osmocom.org/osmo-pcu/commit/?id=f1a75d9b14a8ab103c8ce9fd36b0f8cde9102cab commit f1a75d9b14a8ab103c8ce9fd36b0f8cde9102cab Author: Holger Hans Peter Freyther Date: Sun Oct 27 15:44:21 2013 +0100 bts: Simplify rcv_resource_request, remove logically dead code tbf = find if (tbf) { tbf_free(tbf); tbf = NULL; } if (!tbf) { code... } Remove the if (!tbf) and indention as the tbf is always to be NULL. http://cgit.osmocom.org/osmo-pcu/commit/?id=efa0cf20036305125f285cb1bea2a6fc33bf1508 commit efa0cf20036305125f285cb1bea2a6fc33bf1508 Author: Holger Hans Peter Freyther Date: Sun Oct 27 15:42:25 2013 +0100 bts: Kill dead stores of the tlli/tfi, fix the log message again The code meant to print the tfi and not the tlli. Update it. http://cgit.osmocom.org/osmo-pcu/commit/?id=0a02a944d0932ae293446aa6567bc602e2106679 commit 0a02a944d0932ae293446aa6567bc602e2106679 Author: Holger Hans Peter Freyther Date: Sun Oct 27 13:44:37 2013 +0100 tbf: Remove the trx_no field from the tbf, go through the trx object http://cgit.osmocom.org/osmo-pcu/commit/?id=f8bbd1cddd16c73b6cec1d3f6fc111f079aa81e0 commit f8bbd1cddd16c73b6cec1d3f6fc111f079aa81e0 Author: Holger Hans Peter Freyther Date: Sun Oct 27 13:38:54 2013 +0100 tbf: Go through the trx to get the ARFCN http://cgit.osmocom.org/osmo-pcu/commit/?id=7f1aea0636712b79c4240f7723574ce56de801b8 commit 7f1aea0636712b79c4240f7723574ce56de801b8 Author: Holger Hans Peter Freyther Date: Sun Oct 27 13:35:46 2013 +0100 bts: Further logging improvements for TFI/TLLI output http://cgit.osmocom.org/osmo-pcu/commit/?id=02d9c90290017a78d5bdb7bcbc12a17cc80f21d9 commit 02d9c90290017a78d5bdb7bcbc12a17cc80f21d9 Author: Holger Hans Peter Freyther Date: Sun Oct 27 13:35:30 2013 +0100 bts: Pass the Packet_Control_Acknowledgement_t into the recv method http://cgit.osmocom.org/osmo-pcu/commit/?id=82bdca6378900e48c37a27c76bcf4eb9f53cb3d3 commit 82bdca6378900e48c37a27c76bcf4eb9f53cb3d3 Author: Holger Hans Peter Freyther Date: Sun Oct 27 12:47:48 2013 +0100 bts: Log the TLLI inside the report we get http://cgit.osmocom.org/osmo-pcu/commit/?id=aeeac349229bd1bd0a02fad384ccdfe5c092c0ed commit aeeac349229bd1bd0a02fad384ccdfe5c092c0ed Author: Holger Hans Peter Freyther Date: Sun Oct 27 12:42:58 2013 +0100 tbf: Log the TFI and TLLI so we can try to figure out more from logs <0002> tbf.cpp:444 Poll timeout for DL TBF=0 <0002> tbf.cpp:513 - Timeout for polling PACKET DOWNLINK ACK. <0002> tbf.cpp:688 - Assignment was on PACCH <0002> tbf.cpp:694 - Downlink ACK was received <0008> gprs_bssgp_pcu.cpp:154 LLC [SGSN -> PCU] = TLLI: 0xd6942c78 IMSI: 274080000004765 len: 506 <0002> bts.cpp:974 PACKET DOWNLINK ACK with unknown FN=2213128 TFI=0 (TRX 0 TS 6) http://cgit.osmocom.org/osmo-pcu/commit/?id=1bb89acdcc20086c495d82a8d272696086abb13a commit 1bb89acdcc20086c495d82a8d272696086abb13a Author: Holger Hans Peter Freyther Date: Sun Oct 27 12:30:46 2013 +0100 misc: Change the logging for the tbf and what to log TLLIs got printed as TBF. Fix that but also rename things to TFI. The TFI is not required to be unique per BTS but it is the indicator we use right now. http://cgit.osmocom.org/osmo-pcu/commit/?id=72005c6726d7b39a65ac6bdb3850599e28be2b88 commit 72005c6726d7b39a65ac6bdb3850599e28be2b88 Author: Holger Hans Peter Freyther Date: Sun Oct 27 11:41:01 2013 +0100 bts: Use Packet_Downlink_Ack_Nack_t as parameter http://cgit.osmocom.org/osmo-pcu/commit/?id=15294366b1aa64fc6649585d7dc9a94fb89d0dcc commit 15294366b1aa64fc6649585d7dc9a94fb89d0dcc Author: Holger Hans Peter Freyther Date: Sun Oct 27 11:37:53 2013 +0100 bts: Simplify the code and use Packet_Resource_Request_t* http://cgit.osmocom.org/osmo-pcu/commit/?id=e763594e57453b70274e7ff114af12e42b3a4242 commit e763594e57453b70274e7ff114af12e42b3a4242 Author: Holger Hans Peter Freyther Date: Sun Oct 27 11:19:13 2013 +0100 bts: Work with the Packet_Measurement_Report_t http://cgit.osmocom.org/osmo-pcu/commit/?id=429a710441f7e078b49351eb203066da7e2bc915 commit 429a710441f7e078b49351eb203066da7e2bc915 Author: Holger Hans Peter Freyther Date: Sun Oct 27 11:16:20 2013 +0100 bts: Move the MT_PACKET_MEASUREMENT_REPORT handling to a new method http://cgit.osmocom.org/osmo-pcu/commit/?id=e0a450eae5fb9a8be26bd2edc2026d7cc8391ffa commit e0a450eae5fb9a8be26bd2edc2026d7cc8391ffa Author: Holger Hans Peter Freyther Date: Sun Oct 27 11:11:18 2013 +0100 bts: Move handling of MT_PACKET_RESOURCE_REQUEST to a method Move the code to a new method http://cgit.osmocom.org/osmo-pcu/commit/?id=c83fd500428040538f05ebcbb85cf43a36816722 commit c83fd500428040538f05ebcbb85cf43a36816722 Author: Holger Hans Peter Freyther Date: Sun Oct 27 11:07:17 2013 +0100 bts: Move handling of MT_PACKET_DOWNLINK_ACK_NACK to separate function Kill the tlli assignment as it is never used. http://cgit.osmocom.org/osmo-pcu/commit/?id=07f469c93f22fe41a00b7a9711f9050d1f4431b6 commit 07f469c93f22fe41a00b7a9711f9050d1f4431b6 Author: Holger Hans Peter Freyther Date: Sun Oct 27 11:02:05 2013 +0100 pdch: Move handling of control_ack to a separate method Kill the unused tfi parameter http://cgit.osmocom.org/osmo-pcu/commit/?id=c9b31b92617c24e67970050a43881f9610feba91 commit c9b31b92617c24e67970050a43881f9610feba91 Author: Holger Hans Peter Freyther Date: Sun Oct 27 10:50:35 2013 +0100 bts: Count the rach frames we receive http://cgit.osmocom.org/osmo-pcu/commit/?id=9c82fa6d37fa90b5ba15284ce391996740e4a65e commit 9c82fa6d37fa90b5ba15284ce391996740e4a65e Author: Holger Hans Peter Freyther Date: Sun Oct 27 10:38:31 2013 +0100 misc: Fix typo.. resource in english only has one 's' http://cgit.osmocom.org/osmo-pcu/commit/?id=6e7e95c5d2d65bc89a1c21b0ade182977180a4a9 commit 6e7e95c5d2d65bc89a1c21b0ade182977180a4a9 Author: Holger Hans Peter Freyther Date: Sun Oct 27 10:36:37 2013 +0100 bts: Print the kind of message type not known. http://cgit.osmocom.org/osmo-pcu/commit/?id=e2e83a8955a0cf2ab5368f06d86204e7a839bb22 commit e2e83a8955a0cf2ab5368f06d86204e7a839bb22 Author: Holger Hans Peter Freyther Date: Sun Oct 27 10:34:31 2013 +0100 llc: Count timedout and silently dropped frames A DL tbf can be discarded and then the already queued LLCs will be silently dropped. Count this event. http://cgit.osmocom.org/osmo-pcu/commit/?id=7cc3aa3893e41b6c76b3ef39b6bfe528c5539ed2 commit 7cc3aa3893e41b6c76b3ef39b6bfe528c5539ed2 Author: Holger Hans Peter Freyther Date: Sun Oct 27 10:20:37 2013 +0100 sba: Move freeing a sba into a central place http://cgit.osmocom.org/osmo-pcu/commit/?id=a948795f1daa898f345279c91b94a8d335edf38d commit a948795f1daa898f345279c91b94a8d335edf38d Author: Holger Hans Peter Freyther Date: Sun Oct 27 10:00:47 2013 +0100 sba: Count SBA allocation, frees and timeouts Add a warning about the receive message poking in the internal of the sba. This will be cleaned up in a follow up commit http://cgit.osmocom.org/osmo-pcu/commit/?id=8bc2afce7d722b106fa2a65869bb4a2721fbd056 commit 8bc2afce7d722b106fa2a65869bb4a2721fbd056 Author: Holger Hans Peter Freyther Date: Sun Oct 27 09:50:15 2013 +0100 bts: Provide the first set of counters http://cgit.osmocom.org/osmo-pcu/commit/?id=c9401a36c1f4044f42ed0b6c661bc65d74014af7 commit c9401a36c1f4044f42ed0b6c661bc65d74014af7 Author: Holger Hans Peter Freyther Date: Sun Oct 27 09:02:31 2013 +0100 bts: Start creating statistics inside the BTS code http://cgit.osmocom.org/osmo-pcu/commit/?id=107e7728a21708ec70dbf9ceabd7c3cb5c5f3a67 commit 107e7728a21708ec70dbf9ceabd7c3cb5c5f3a67 Author: Holger Hans Peter Freyther Date: Sat Oct 26 21:48:38 2013 +0200 tbf: Move gprs_rlcmac_send_data_block_acknowledged into tbf We can now remove the gprs_rlcmac_data as the code has been moved into the tbf, pdch and bts. http://cgit.osmocom.org/osmo-pcu/commit/?id=f39db9fc87a0944104e63ff49d31b80d4dd73a53 commit f39db9fc87a0944104e63ff49d31b80d4dd73a53 Author: Holger Hans Peter Freyther Date: Sat Oct 26 21:38:30 2013 +0200 tbf: Move gprs_rlcmac_send_packet_uplink_assignment into the tbf http://cgit.osmocom.org/osmo-pcu/commit/?id=cc711d0b7bfa6a9b133c04a7925ca62667c4ef72 commit cc711d0b7bfa6a9b133c04a7925ca62667c4ef72 Author: Holger Hans Peter Freyther Date: Sat Oct 26 21:20:51 2013 +0200 tbf: Move gprs_rlcmac_send_packet_uplink_assignment to the tbf Again the function was called send but didn't do any sending http://cgit.osmocom.org/osmo-pcu/commit/?id=c1058fc85ee07321a80b1ddb91c8af8b183e4f12 commit c1058fc85ee07321a80b1ddb91c8af8b183e4f12 Author: Holger Hans Peter Freyther Date: Sat Oct 26 21:07:45 2013 +0200 tbf: Fix typo in thecomment http://cgit.osmocom.org/osmo-pcu/commit/?id=16d7a115d1af6f845254c526f4de28e2ffa5199f commit 16d7a115d1af6f845254c526f4de28e2ffa5199f Author: Holger Hans Peter Freyther Date: Sat Oct 26 21:04:28 2013 +0200 tbf: Move gprs_rlcmac_send_uplink_ack into the tbf The method was called send but didn't send anything. Move it to the tbf http://cgit.osmocom.org/osmo-pcu/commit/?id=8d26433a04e40fa3d5a1ff3df0bb6168f96ca8e4 commit 8d26433a04e40fa3d5a1ff3df0bb6168f96ca8e4 Author: Holger Hans Peter Freyther Date: Sat Oct 26 20:56:20 2013 +0200 bts: Move gprs_rlcmac_rcv_rach into the BTS class http://cgit.osmocom.org/osmo-pcu/commit/?id=fa96209ed1ad628c55e45707180b7106252f5697 commit fa96209ed1ad628c55e45707180b7106252f5697 Author: Holger Hans Peter Freyther Date: Sat Oct 26 20:45:35 2013 +0200 tbf: Move gprs_rlcmac_send_packet_downlink_assignment into the tbf This method was called _send_packet_ but actually didn't do any sending at all. It just formated the right assignment. I replaced tbf-> with nothing. http://cgit.osmocom.org/osmo-pcu/commit/?id=9fa714f1be53603486879dc738cc74fc22956776 commit 9fa714f1be53603486879dc738cc74fc22956776 Author: Holger Hans Peter Freyther Date: Sat Oct 26 20:27:44 2013 +0200 bts: Move gprs_rlcmac_trigger_downlink_assignment into BTS http://cgit.osmocom.org/osmo-pcu/commit/?id=965db4438724e7ce248fa4e6346ff1955508eca0 commit 965db4438724e7ce248fa4e6346ff1955508eca0 Author: Holger Hans Peter Freyther Date: Sat Oct 26 20:21:11 2013 +0200 debug_dl_ass_idle: Remove the feature as it is obviously broken strncpy takes three arguments but only two are given. This feature would also only work if there is one tbf at a time. http://cgit.osmocom.org/osmo-pcu/commit/?id=c95e9d210130e50da1a5766592f88536e977bc56 commit c95e9d210130e50da1a5766592f88536e977bc56 Author: Holger Hans Peter Freyther Date: Sat Oct 26 20:12:59 2013 +0200 tbf: Move gprs_rlcmac_poll_timeout into the tbf Move the gprs_rlcmac_poll_timeout method into the tbf class and gprs_rlcmac_downlink_assignment into the BTS. http://cgit.osmocom.org/osmo-pcu/commit/?id=c9d6f2b3da04452810033d7dae6fb8e81dc046c2 commit c9d6f2b3da04452810033d7dae6fb8e81dc046c2 Author: Holger Hans Peter Freyther Date: Sat Oct 26 19:49:16 2013 +0200 bts: Move rcv_imm_ass_cnf into the bts code http://cgit.osmocom.org/osmo-pcu/commit/?id=af06982d79d3d64ed354b2715ab41e5e04ccbe71 commit af06982d79d3d64ed354b2715ab41e5e04ccbe71 Author: Holger Hans Peter Freyther Date: Sat Oct 26 19:43:50 2013 +0200 tbf: kill the indirection and invoke the right method http://cgit.osmocom.org/osmo-pcu/commit/?id=4e1c43d5994670efdbd7d9eb6e241c646d62c1ca commit 4e1c43d5994670efdbd7d9eb6e241c646d62c1ca Author: Holger Hans Peter Freyther Date: Sat Oct 26 19:17:58 2013 +0200 tbf/bts: Move the tfi_find_free into the bts http://cgit.osmocom.org/osmo-pcu/commit/?id=f1f8fb4405149ccdfb7879b317eab00d173608e0 commit f1f8fb4405149ccdfb7879b317eab00d173608e0 Author: Holger Hans Peter Freyther Date: Sat Oct 26 19:10:43 2013 +0200 tbf/pdch/bts: Move the tbf look-up by tfi into the BTS http://cgit.osmocom.org/osmo-pcu/commit/?id=054c6b2a0833742b3bd9c6abb996ca5a4c6b1d64 commit 054c6b2a0833742b3bd9c6abb996ca5a4c6b1d64 Author: Holger Hans Peter Freyther Date: Sat Oct 26 19:05:42 2013 +0200 pdch/tbf: Add another todo item for badly placed code... http://cgit.osmocom.org/osmo-pcu/commit/?id=1b9749747e6fc749280223464698842e1ecb0170 commit 1b9749747e6fc749280223464698842e1ecb0170 Author: Holger Hans Peter Freyther Date: Sat Oct 26 18:56:43 2013 +0200 sba/pdch: Use thepdch to look up a sba for a frame number http://cgit.osmocom.org/osmo-pcu/commit/?id=332e4ccdebbcbf771d28d4020f82063ef6b28b54 commit 332e4ccdebbcbf771d28d4020f82063ef6b28b54 Author: Holger Hans Peter Freyther Date: Sat Oct 26 18:53:16 2013 +0200 pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand Simplify the depedencies and use the inline functions when we need to figure out the numbers. http://cgit.osmocom.org/osmo-pcu/commit/?id=f21b39841992be54dbd4b52ff4318fe92ffed3bd commit f21b39841992be54dbd4b52ff4318fe92ffed3bd Author: Holger Hans Peter Freyther Date: Sat Oct 26 18:45:19 2013 +0200 pdch: Remove the bts argument from rcv_control_block http://cgit.osmocom.org/osmo-pcu/commit/?id=d746dc93bba4aa12aa54af203fbdd764e590e9d4 commit d746dc93bba4aa12aa54af203fbdd764e590e9d4 Author: Holger Hans Peter Freyther Date: Sat Oct 26 18:39:36 2013 +0200 pdch: Remove the the bts parameter from rcv_data_block_acknowledged http://cgit.osmocom.org/osmo-pcu/commit/?id=2f381d671ab82f0157a2a0a5c4b538d9fba2bbdc commit 2f381d671ab82f0157a2a0a5c4b538d9fba2bbdc Author: Holger Hans Peter Freyther Date: Sat Oct 26 18:32:13 2013 +0200 tbf: Fix typo in the debug message http://cgit.osmocom.org/osmo-pcu/commit/?id=61c50fcfe9fa4ba59f9d5a4d41761ff67fe71262 commit 61c50fcfe9fa4ba59f9d5a4d41761ff67fe71262 Author: Holger Hans Peter Freyther Date: Sat Oct 26 18:31:51 2013 +0200 tbf: Add todo item tht could help improving debugging http://cgit.osmocom.org/osmo-pcu/commit/?id=010f4d914735c94a8088592525c290356e6dc9b7 commit 010f4d914735c94a8088592525c290356e6dc9b7 Author: Holger Hans Peter Freyther Date: Sat Oct 26 18:01:35 2013 +0200 tbf: Move the timer routine into the class The timer is used for various timeouts and there is still external client code that is calling it. In a perfect world the client code would indicate that an event has happened and the internal timer will be stopped. The best compromise is the "stop_t3191" method. It allows to add semantic verification that the timer has been running. http://cgit.osmocom.org/osmo-pcu/commit/?id=fa1c53cf044a71b66c6b6195cae9db85649a90be commit fa1c53cf044a71b66c6b6195cae9db85649a90be Author: Holger Hans Peter Freyther Date: Sat Oct 26 17:56:15 2013 +0200 tbf: Move the handle tineout into the tbf class http://cgit.osmocom.org/osmo-pcu/commit/?id=04aad882a0b74a63e42be7cd48eed676803ab5fd commit 04aad882a0b74a63e42be7cd48eed676803ab5fd Author: Holger Hans Peter Freyther Date: Sat Oct 26 17:49:36 2013 +0200 tbf: Move the updating of the data into the tbf class http://cgit.osmocom.org/osmo-pcu/commit/?id=017fe6f52dee157f3a0c62b7d6492d6a989733ee commit 017fe6f52dee157f3a0c62b7d6492d6a989733ee Author: Holger Hans Peter Freyther Date: Sat Oct 26 17:38:37 2013 +0200 pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block Move the dispatch into the PDCH. This needs to be split up further into understandable blocks. http://cgit.osmocom.org/osmo-pcu/commit/?id=38168955f3e139489cf664bc9870bb58939a9bc6 commit 38168955f3e139489cf664bc9870bb58939a9bc6 Author: Holger Hans Peter Freyther Date: Sat Oct 26 17:32:04 2013 +0200 pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF. http://cgit.osmocom.org/osmo-pcu/commit/?id=0367f247f953e0c7878b2ede47701dbf08d6dd65 commit 0367f247f953e0c7878b2ede47701dbf08d6dd65 Author: Holger Hans Peter Freyther Date: Sat Oct 26 16:54:10 2013 +0200 pdch: Move the dispatch of gprs_rlcmac_rcv_block into the pdch http://cgit.osmocom.org/osmo-pcu/commit/?id=8fb190fa212264f9a1f903f858ab3bfb68c3c736 commit 8fb190fa212264f9a1f903f858ab3bfb68c3c736 Author: Holger Hans Peter Freyther Date: Sat Oct 26 16:42:38 2013 +0200 pdch: Instead of passing bts, trx, ts use the pdch All dispatching will go through the PDCH. This will clean a lot of the look-ups inside the gprs_rlcmac_data.c and continue with adding structure to the pcu code. http://cgit.osmocom.org/osmo-pcu/commit/?id=90c99b1836d05cffad91db7b7078e88eb1ec8188 commit 90c99b1836d05cffad91db7b7078e88eb1ec8188 Author: Holger Hans Peter Freyther Date: Sun Oct 20 17:10:25 2013 +0200 misc: Remove the bts parameter from calls that take a tbf Mark some of the tbf manipulation that is burried in the data sending routine.. that it should be moved around. http://cgit.osmocom.org/osmo-pcu/commit/?id=84203dac1ecd37c8d4ed6decbf041e2c709b42f7 commit 84203dac1ecd37c8d4ed6decbf041e2c709b42f7 Author: Holger Hans Peter Freyther Date: Sun Oct 20 16:48:56 2013 +0200 sched: Add another warning about trx->arfcn and arfcn.. http://cgit.osmocom.org/osmo-pcu/commit/?id=7b6f641e42f5e71116a7cc0b1ee6c44d9577b678 commit 7b6f641e42f5e71116a7cc0b1ee6c44d9577b678 Author: Holger Hans Peter Freyther Date: Sun Oct 20 16:45:10 2013 +0200 alloc: Remove the ts parameter from the internal interface http://cgit.osmocom.org/osmo-pcu/commit/?id=6f9541c1048248d223790a448da64a0a6558a2f4 commit 6f9541c1048248d223790a448da64a0a6558a2f4 Author: Holger Hans Peter Freyther Date: Sun Oct 20 16:37:05 2013 +0200 pdch: Simplify the reset code, rename variables to XYZ_no Simplify the reset code now that the PDCH can know where it is located. Rename the variables in the sba to trx_no and ts_no as it stores the number and not the actual thing. http://cgit.osmocom.org/osmo-pcu/commit/?id=abdb35a7dc9d2b7032718f16cb3c2bcbce4d705c commit abdb35a7dc9d2b7032718f16cb3c2bcbce4d705c Author: Holger Hans Peter Freyther Date: Sun Oct 20 10:14:03 2013 +0200 bts: Add backpointers to the PDCH and TRX structures This will allow to kill various parameters from all the functions as we can walk back. http://cgit.osmocom.org/osmo-pcu/commit/?id=92bc1d6cbfec1f08088564fd4fdb0f19b6b7041f commit 92bc1d6cbfec1f08088564fd4fdb0f19b6b7041f Author: Holger Hans Peter Freyther Date: Sun Oct 20 08:44:02 2013 +0200 tbf: First round of removing llc handling from the rlcmac_data The code in gprs_rlcmac_data should ask the TBF for help in packing the frames but it really shouldn't poke in the internals of the tbf structure. This is very bad capsuling and has plenty of copy and paste. At the same thime this will be the most dangerous refactoring of the code base. http://cgit.osmocom.org/osmo-pcu/commit/?id=9f8f13ad196be7ae0cf5526503e985766e7f6925 commit 9f8f13ad196be7ae0cf5526503e985766e7f6925 Author: Holger Hans Peter Freyther Date: Sun Oct 20 08:28:25 2013 +0200 data: Move gprs_rlcmac_cs to the place it is used and make static http://cgit.osmocom.org/osmo-pcu/commit/?id=177f04e486c07b0fd2ae3f14b92a5b72c1e4a259 commit 177f04e486c07b0fd2ae3f14b92a5b72c1e4a259 Author: Holger Hans Peter Freyther Date: Sat Oct 19 21:10:38 2013 +0200 bts/tbf: Move the lists into the BTS and do the look-up from the BTS The list belongs to the BTS. This makes cleaning this up more easy and establishes a hierachy of resources that start from the BTS. The debug_diagram code is now broken. http://cgit.osmocom.org/osmo-pcu/commit/?id=66ae33cce7221ca68d9c59040b665877d983c7c5 commit 66ae33cce7221ca68d9c59040b665877d983c7c5 Author: Holger Hans Peter Freyther Date: Sat Oct 19 21:24:34 2013 +0200 tbf: Keep a pointer from the tbf to the BTS This is preparing the next commits and will ease working with the debug_diagram when the global lists are killed. It will simplify the APIin the long run. http://cgit.osmocom.org/osmo-pcu/commit/?id=50457867b50f4651875c83b95023b390c62f7c12 commit 50457867b50f4651875c83b95023b390c62f7c12 Author: Holger Hans Peter Freyther Date: Sat Oct 19 20:47:12 2013 +0200 sba: Create a SBAController that will manage the sbas for a BTS The PollController is a friend of the SBAController and is allowed to access the internal list. The list is hidden from everyone else. This is done because the calculation of timeout should belong into the PollController and not into the SBAController. http://cgit.osmocom.org/osmo-pcu/commit/?id=0e83a081fdd1847ece2d8f453892507724b60f5b commit 0e83a081fdd1847ece2d8f453892507724b60f5b Author: Holger Hans Peter Freyther Date: Sat Oct 19 20:11:46 2013 +0200 sba: Move the sba code to a dedicated file Move the code around and then turn it into an object... http://cgit.osmocom.org/osmo-pcu/commit/?id=f74ccd033c89078ca79afa8fe56760b0720dba49 commit f74ccd033c89078ca79afa8fe56760b0720dba49 Author: Holger Hans Peter Freyther Date: Sat Oct 19 20:04:57 2013 +0200 ta: Create TimingAdvance class and make it belong to the BTS This allows us to easily flush the state in case a PCU/BTS connection is lost. http://cgit.osmocom.org/osmo-pcu/commit/?id=74065216b73d654e16b87c6795234e1ff777e98d commit 74065216b73d654e16b87c6795234e1ff777e98d Author: Holger Hans Peter Freyther Date: Sat Oct 19 19:50:00 2013 +0200 ta: Move timing advance related code into the ta.cpp file http://cgit.osmocom.org/osmo-pcu/commit/?id=7e6942d126571ce735fcb8a61d417cbe602d7547 commit 7e6942d126571ce735fcb8a61d417cbe602d7547 Author: Holger Hans Peter Freyther Date: Sat Oct 19 19:04:03 2013 +0200 encoding: Move the functions into the encoding class Add some TODO to this class. E.g. they could all work on the bitvec and the parameter handling could better. http://cgit.osmocom.org/osmo-pcu/commit/?id=7c406b85166f56e5390e9b36a339f4350e93dc2c commit 7c406b85166f56e5390e9b36a339f4350e93dc2c Author: Holger Hans Peter Freyther Date: Sat Oct 19 18:50:22 2013 +0200 encoding: Move encoding routines into a separate file http://cgit.osmocom.org/osmo-pcu/commit/?id=c7b04c46a674ee79b24df99c0e21c9cb4fe56eae commit c7b04c46a674ee79b24df99c0e21c9cb4fe56eae Author: Holger Hans Peter Freyther Date: Sat Oct 19 18:33:52 2013 +0200 pdch: Only say we have paged when this has actually been done http://cgit.osmocom.org/osmo-pcu/commit/?id=8bee1ec44efaf4e887ef65be539249aecea5245b commit 8bee1ec44efaf4e887ef65be539249aecea5245b Author: Holger Hans Peter Freyther Date: Sat Oct 19 18:28:59 2013 +0200 bts/pdch: Move the adding of paging to the BTS/PDCH objects Only the gprs_rlcmac_pdch will manipulate the paging list now. There can be various more refactorings of the code but they can be done later. E.g. on memory allocation failure we can continue instead of leaving the code, we should also set any_tbf only after things have been paged. http://cgit.osmocom.org/osmo-pcu/commit/?id=c1cd4864861c77e24d34cb25aeeeaa3a36aa65a0 commit c1cd4864861c77e24d34cb25aeeeaa3a36aa65a0 Author: Holger Hans Peter Freyther Date: Sat Oct 19 18:15:44 2013 +0200 pdch: Move paging dequeue into the PDCH object Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well. ----------------------------------------------------------------------- Summary of changes: tests/alloc/AllocTest.cpp | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) hooks/post-receive -- UNNAMED PROJECT