From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Thu, 12 Dec 2013 10:12:01 GMT Message-ID: <201312121012.rBCAC1x7000728@git.osmocom.org> Subject: osmo-pcu.git branch sysmocom/master updated. 0.2-253-g752a3b2 Message: 14 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "UNNAMED PROJECT". The branch, sysmocom/master has been updated via 752a3b2baaf5c0b5323271ef1e03a3609b487286 (commit) via 5e94cd4fdedc44ba178a9d3d150f0d5ba7abc742 (commit) via cc5a4cbe9ba583189c0d007215f51f7986b4e261 (commit) via 48df40d2a4ca216f08e8161701918fe5b7bf9edd (commit) via f1786a375f0db36398c9c2f17634f9ee2d1f643f (commit) via 6f7cb2cb4ff407f0af696eb9ce23bd2290450ef9 (commit) via 0f2b5fc749a9954c41f05ca7391ffae705468af3 (commit) via 5241c1a018a27b1372f3d02c564acb5188b73ee2 (commit) via 52ea8a0d87e695ba3cafedc53498ee53a72ffaf9 (commit) via e6e605ba8641d14fa84be9baecba105e5b0901ec (commit) via c3f4330fa3a2cf6328cfddd9f00a1b6fd1cb51c3 (commit) via f86fb7a953cc020d4bc1bdf67179ae69436aa730 (commit) via 8a31f9e016067991b426e0be7637dd38002f1c3e (commit) from 11f2d58dbd0f590da3612a9f587a23b92857436f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/osmo-pcu/commit/?id=752a3b2baaf5c0b5323271ef1e03a3609b487286 commit 752a3b2baaf5c0b5323271ef1e03a3609b487286 Merge: 11f2d58 5e94cd4 Author: Holger Hans Peter Freyther Date: Thu Dec 12 11:11:02 2013 +0100 Merge branch 'sysmocom/gprs-window-handling' into sysmocom/master Daniel and me worked on the window handling. We now test that what we encode is compatible to what we decode. The char array now includes SSN-1 to the right of the array (reflecting a time axis that grows towards the right..) http://cgit.osmocom.org/osmo-pcu/commit/?id=5e94cd4fdedc44ba178a9d3d150f0d5ba7abc742 commit 5e94cd4fdedc44ba178a9d3d150f0d5ba7abc742 Author: Daniel Willmann Date: Wed Dec 11 20:11:16 2013 +0100 decoding: Cosmetic - change rbb decoding http://cgit.osmocom.org/osmo-pcu/commit/?id=cc5a4cbe9ba583189c0d007215f51f7986b4e261 commit cc5a4cbe9ba583189c0d007215f51f7986b4e261 Author: Daniel Willmann Date: Wed Dec 11 20:04:29 2013 +0100 rlc: Make the update loop more understandable Add bitnum_to_bsn() as a convenience function to get the BSN, use it in the update handling and ignore rbb for values outside of our tx window. http://cgit.osmocom.org/osmo-pcu/commit/?id=48df40d2a4ca216f08e8161701918fe5b7bf9edd commit 48df40d2a4ca216f08e8161701918fe5b7bf9edd Author: Daniel Willmann Date: Wed Dec 11 16:51:26 2013 +0100 tests/TypesTest: Check rbb handling in DL http://cgit.osmocom.org/osmo-pcu/commit/?id=f1786a375f0db36398c9c2f17634f9ee2d1f643f commit f1786a375f0db36398c9c2f17634f9ee2d1f643f Author: Daniel Willmann Date: Wed Dec 11 18:44:49 2013 +0100 tests/TypesTest: Ensure that extract_rbb(encode_rbb(x)) == x http://cgit.osmocom.org/osmo-pcu/commit/?id=6f7cb2cb4ff407f0af696eb9ce23bd2290450ef9 commit 6f7cb2cb4ff407f0af696eb9ce23bd2290450ef9 Author: Daniel Willmann Date: Wed Dec 11 14:25:20 2013 +0100 decoding: Use 'I' and 'R' in rbb array for DL We want to match up rbb decoding and encoding so it helps to use the same chars. http://cgit.osmocom.org/osmo-pcu/commit/?id=0f2b5fc749a9954c41f05ca7391ffae705468af3 commit 0f2b5fc749a9954c41f05ca7391ffae705468af3 Author: Daniel Willmann Date: Wed Dec 11 16:49:43 2013 +0100 tests/TypesTest: Print the result of Encoding::encode_rbb() http://cgit.osmocom.org/osmo-pcu/commit/?id=5241c1a018a27b1372f3d02c564acb5188b73ee2 commit 5241c1a018a27b1372f3d02c564acb5188b73ee2 Author: Daniel Willmann Date: Wed Dec 11 14:35:29 2013 +0100 encoding: Factor out encode_rbb to help testing http://cgit.osmocom.org/osmo-pcu/commit/?id=52ea8a0d87e695ba3cafedc53498ee53a72ffaf9 commit 52ea8a0d87e695ba3cafedc53498ee53a72ffaf9 Author: Daniel Willmann Date: Wed Nov 27 17:09:17 2013 +0100 encoding: Use ul_window ssn()/update_rbb() methods when encoding ul ACK Use the ssn() and update_rbb() methods of gprs_rlc_ul_window when encoding the ACK/NACK packet in write_packet_uplink_ack() http://cgit.osmocom.org/osmo-pcu/commit/?id=e6e605ba8641d14fa84be9baecba105e5b0901ec commit e6e605ba8641d14fa84be9baecba105e5b0901ec Author: Daniel Willmann Date: Wed Nov 27 18:47:43 2013 +0100 encoding: Change wording to match that of 3GPP TS 04.60 The spec (in ch. 9.1.8.1) speaks of RECEIVED or INVALID in the RLC receiver, so change the wording in the log message to match. http://cgit.osmocom.org/osmo-pcu/commit/?id=c3f4330fa3a2cf6328cfddd9f00a1b6fd1cb51c3 commit c3f4330fa3a2cf6328cfddd9f00a1b6fd1cb51c3 Author: Daniel Willmann Date: Wed Dec 11 16:47:19 2013 +0100 tests/TypesTest: Add OSMO_ASSERT_STR_EQ which prints out the parameters Use it to compare rbb http://cgit.osmocom.org/osmo-pcu/commit/?id=f86fb7a953cc020d4bc1bdf67179ae69436aa730 commit f86fb7a953cc020d4bc1bdf67179ae69436aa730 Author: Daniel Willmann Date: Wed Nov 27 17:56:02 2013 +0100 tests/TypesTest: Test ssn() and update_rbb() uplink window methods in TypesTest Test that ssn and rbb are updated correctly. http://cgit.osmocom.org/osmo-pcu/commit/?id=8a31f9e016067991b426e0be7637dd38002f1c3e commit 8a31f9e016067991b426e0be7637dd38002f1c3e Author: Daniel Willmann Date: Wed Nov 27 17:08:35 2013 +0100 rlc: Manage the received block bitmap in the ul_window Added two methods to gprs_rlc_ul_window * ssn() returns the starting sequence number * update_rbb() returns an array of chars representing the state of the received block bitmap. Each element is either 'I'nvalid or 'R'eceived. The rbb is generated from v_n rbb[63] relates to BSN ssn-1 ... rbb[0] relates to BSN ssn-64 ----------------------------------------------------------------------- Summary of changes: src/decoding.cpp | 8 ++-- src/encoding.cpp | 53 ++++++++++++++------------ src/encoding.h | 2 + src/rlc.cpp | 30 +++++++++++---- src/rlc.h | 8 ++++ src/tbf.cpp | 2 +- tests/types/TypesTest.cpp | 95 +++++++++++++++++++++++++++++++++++++++++++++++ tests/types/TypesTest.ok | 6 +++ 8 files changed, 170 insertions(+), 34 deletions(-) hooks/post-receive -- UNNAMED PROJECT