From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Sat, 09 Feb 2013 13:30:11 +0100 Message-ID: Subject: osmo-bts.git branch master updated. 0.1.0-51-g98407bd Message: 1 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Osmocom BTS-side code (Abis, scheduling, ...)". The branch, master has been updated via 98407bd457b88c1a26de2a9955de3de9846e4f68 (commit) via 0bb2974b370080b43282323364ebc6b0b6480803 (commit) via 550d22be5b2ddc376ccae937bd34c921dcf4a071 (commit) from 6a2d89f48d0727238eb2c14c7bfb4f0517d3be81 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=98407bd457b88c1a26de2a9955de3de9846e4f68 commit 98407bd457b88c1a26de2a9955de3de9846e4f68 Author: Harald Welte Date: Sat Feb 9 11:44:07 2013 +0100 rsl: Fix compiler warning in use of osmo_rtp_get_bound_ip_port() for whatever reason i decided that a port number in osmo_rtp_get_bound_ip_port() needs to be a int * and not a uint16_t * at the time, so we have to deal with this here rather than breaking the ABI. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=0bb2974b370080b43282323364ebc6b0b6480803 commit 0bb2974b370080b43282323364ebc6b0b6480803 Author: Harald Welte Date: Sat Feb 9 11:38:30 2013 +0100 Fix determination of locally bound IP for RTP sockets After we create a socket and bind it to INADDR_ANY, we cannot yet use getsockname() to resolve the locally bound IP. This only works after the socket has been connected to the remote IP. So we have to move the osmo_rtp_get_bound_ip_port() to a code section after osmo_rtp_socket_connect() has already happened. With the code prior to this commit, unless "rtp bind-ip" was used in the config file, we reported "0.0.0.0" as the "Source IP AddresS" in the IPA CRCX ACK to the BSC. This is of course wrong, as the BSC will then use this "0.0.0.0" as destination address for the incoming RTP stream :( Please note that for this fix to work, you also need a libosmoabis.git with commit d426d458ca96ba29793e35b1b2a73fbcb3b2c888 which actually causes osmo_rtp_socket_connect() to actually issue connect() on the socket at all. http://cgit.osmocom.org/cgit/osmo-bts/commit/?id=550d22be5b2ddc376ccae937bd34c921dcf4a071 commit 550d22be5b2ddc376ccae937bd34c921dcf4a071 Author: Harald Welte Date: Sun Feb 3 16:35:07 2013 +0100 Deprecate the "rtp bind-ip" configuration directive Instead of explicitly having to specify the local IP address for RTP sockets in the BTS, we just use "0.0.0.0" instead, which gets translated to INADDR_ANY. We still accept the configuration directive in old config files, but when we write, the line will no longer be re-written to the file. TODO: IMHO, the IPA RSL CRCX/MDCX actually permit the BSC to specify the IP address on the BTS side, and we probably simply ignore this at this point. ----------------------------------------------------------------------- Summary of changes: include/osmo-bts/gsm_data.h | 1 - src/common/rsl.c | 22 +++++++++++++--------- src/common/vty.c | 13 +++---------- 3 files changed, 16 insertions(+), 20 deletions(-) hooks/post-receive -- Osmocom BTS-side code (Abis, scheduling, ...)