From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Thu, 20 Dec 2012 19:00:30 +0100 Message-ID: Subject: openbsc.git branch zecke/channel-release updated. 0.12.0-185-g02e71cd Message: 3 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, zecke/channel-release has been updated discards def8944e27039d8218d6a51f9847c7aa72e32ca8 (commit) discards 73c9d53fbc18592a1330ea43d71023da5ca89889 (commit) discards 315c2030dcfe714644f47e016f281bf30820f834 (commit) discards fe203c2250febba01e9d88dfb4affa2cfb0ae34f (commit) discards 551902d5b24f4812ebf711f35fa99e8e1103347e (commit) discards 1018b02b91d75ba3c8b19cbdfd56694db6905cfd (commit) discards a255be9ecf849208db326f1ae8914c8b27062cd9 (commit) discards ff30c8427ad2941e9f245359025b6529ee65a01f (commit) discards b06aa9acf3ed6900db37d10667a9e29db3494760 (commit) via 02e71cd98a40e3dac4ac4a10dc80ff955a4c73dc (commit) via b061c39d49332531b22fb8a03b7306bfe3a11ea2 (commit) via f70d0d7328e297062a386761a363f39e7770e166 (commit) via 987f0a59613d210608872db47d98988b37f1caa0 (commit) via 82db74e0f83ef456fdd3a9f52d8a2514d82ba72c (commit) via b71f5569d269f3fcc7888beeb0370e7b1201cb21 (commit) via ffceee9d7c45ade1e1834a7e3166eed3404f151c (commit) via 1d391186e3251625bd7fc266e226fb997f29c581 (commit) via f907346eae7142dd0bd1040e592f3fcbb957d6b4 (commit) via 3a41b80bd7868ced91abb2d48662024f5e50d1cb (commit) via 2f25747e3f74dfa743363fb36069b78a19e0ce98 (commit) via bce5675e5fa1eb4bcbe0dd24d503456eaeb58a0d (commit) via c751cf92cbc25a5cfca8041ef3fdcc16ed5865ad (commit) via 408208d8874a0f227d09e299db2346fc3f67b5ca (commit) via 5ea1bc77a3947f541d576f95e7ecc7249fc65b9b (commit) via 7e7ee5f8c6904a607e7505021c16de4c26dadbe0 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (def8944e27039d8218d6a51f9847c7aa72e32ca8) \ N -- N -- N (02e71cd98a40e3dac4ac4a10dc80ff955a4c73dc) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/openbsc/commit/?id=02e71cd98a40e3dac4ac4a10dc80ff955a4c73dc commit 02e71cd98a40e3dac4ac4a10dc80ff955a4c73dc Author: Holger Hans Peter Freyther Date: Wed Dec 28 16:21:05 2011 +0100 lchan: Introduce T3109 handling for the release procedure T3109 is started when the SACCH is deactivated. It is stopped when the phones sends the DISC/UA/UM on LAPDm for the main signalling link. In case of timeout the abnormal release procedure will be initiated. Make sure to not issue the SACCH Deactivate twice to avoid confusing the equipment. This is still not fully spec compliant. In case of a timeout the abnormal release handling will be started which involves starting T3111+2. The error handling should be split out of the rf channel release method, e.g. lchan_release should be called and check if the channel release was already initiated. http://cgit.osmocom.org/cgit/openbsc/commit/?id=b061c39d49332531b22fb8a03b7306bfe3a11ea2 commit b061c39d49332531b22fb8a03b7306bfe3a11ea2 Author: Holger Hans Peter Freyther Date: Thu Dec 6 19:25:06 2012 +0100 lchan: Introduce a BROKEN state for the lchan If the CHAN ACTIV is NACKED we set the state backto NONE. This is problematic as our channel allocator will allocate from the front or from the back and if the channel is early in the list it might cause permanent failures. Introduce a BROKEN state and use it when the channel activation is failing for an unknown reason. Copy the cause so it can be inspected later. http://cgit.osmocom.org/cgit/openbsc/commit/?id=f70d0d7328e297062a386761a363f39e7770e166 commit f70d0d7328e297062a386761a363f39e7770e166 Author: Holger Hans Peter Freyther Date: Wed Dec 28 12:11:40 2011 +0100 lchan: Document the behavior/quirks for abnormal channel release Deactivate the SACCH and release all SAPIs locally as of GSM 04.08. Add documentation to the code and explain what will happen as part of the release process. http://cgit.osmocom.org/cgit/openbsc/commit/?id=987f0a59613d210608872db47d98988b37f1caa0 commit 987f0a59613d210608872db47d98988b37f1caa0 Author: Holger Hans Peter Freyther Date: Tue Dec 27 22:24:17 2011 +0100 lchan: Release the lchan more quickly, align with GSM 04.08 * Release all channels with SAPI > 0 with the "local end release" (as of NOTE 1 of GSM 04.08). * No need to wait for all SAPIs to be torn down and the normal REL_IND/REL_CONF will call rsl_handle_release and the channel should be released. * Update the documentation http://cgit.osmocom.org/cgit/openbsc/commit/?id=82db74e0f83ef456fdd3a9f52d8a2514d82ba72c commit 82db74e0f83ef456fdd3a9f52d8a2514d82ba72c Author: Holger Hans Peter Freyther Date: Tue Dec 27 21:43:22 2011 +0100 lchan: Release all higher sapis on the local end. According to GSM 04.08 3.4.13.1.1 RR connection release in NOTE 1 one should release all non main signaling links using the local end link release. http://cgit.osmocom.org/cgit/openbsc/commit/?id=b71f5569d269f3fcc7888beeb0370e7b1201cb21 commit b71f5569d269f3fcc7888beeb0370e7b1201cb21 Author: Holger Hans Peter Freyther Date: Thu Dec 6 19:09:58 2012 +0100 rsl: Cosmetic changes to the release code Put the idiom that sets the lchan state to none and respecting the error state into a shared method. This way the special handling for the abnormal case is just in one place. http://cgit.osmocom.org/cgit/openbsc/commit/?id=ffceee9d7c45ade1e1834a7e3166eed3404f151c commit ffceee9d7c45ade1e1834a7e3166eed3404f151c Author: Holger Hans Peter Freyther Date: Thu Dec 6 12:20:56 2012 +0100 rsl: Call the release function with the enum name and not the number Done with the semantic patch: @rule1@ expression E; expression F; @@ - lchan_release(E, F, 1); + lchan_release(E, F, RSL_REL_LOCAL_END); @rule2@ expression E; expression F; @@ - lchan_release(E, F, 0); + lchan_release(E, F, RSL_REL_NORMAL); http://cgit.osmocom.org/cgit/openbsc/commit/?id=1d391186e3251625bd7fc266e226fb997f29c581 commit 1d391186e3251625bd7fc266e226fb997f29c581 Author: Holger Hans Peter Freyther Date: Thu Dec 6 12:01:38 2012 +0100 rsl: Rename the reason to release_mode and use the enum value The API with 0 and 1 as legal values is hard to understand. Use the recently introduced enum values instead. http://cgit.osmocom.org/cgit/openbsc/commit/?id=f907346eae7142dd0bd1040e592f3fcbb957d6b4 commit f907346eae7142dd0bd1040e592f3fcbb957d6b4 Author: Holger Hans Peter Freyther Date: Thu Dec 6 19:00:35 2012 +0100 rsl: Use LOGL_ERROR instead of LOGL_NOTICE act/deact timeouts It is a grave error when the BTS does not respond to the ACT/DEACT requests, use LOGL_ERROR for such conditions. ----------------------------------------------------------------------- Summary of changes: openbsc/.gitignore | 1 + openbsc/configure.ac | 3 +- openbsc/include/openbsc/abis_nm.h | 16 +++ openbsc/include/openbsc/mgcp.h | 1 + openbsc/include/openbsc/mgcp_internal.h | 2 + openbsc/src/gprs/gb_proxy.c | 7 -- openbsc/src/libbsc/abis_nm.c | 104 +++++++++++++------ openbsc/src/libmgcp/mgcp_network.c | 2 +- openbsc/src/libmgcp/mgcp_protocol.c | 11 ++- openbsc/src/libmgcp/mgcp_vty.c | 36 +++++++ openbsc/src/libmsc/gsm_04_08.c | 1 - openbsc/tests/Makefile.am | 2 +- openbsc/tests/abis/Makefile.am | 17 +++ openbsc/tests/abis/abis_test.c | 169 +++++++++++++++++++++++++++++++ openbsc/tests/abis/abis_test.ok | 17 +++ openbsc/tests/testsuite.at | 6 + 16 files changed, 351 insertions(+), 44 deletions(-) create mode 100644 openbsc/tests/abis/Makefile.am create mode 100644 openbsc/tests/abis/abis_test.c create mode 100644 openbsc/tests/abis/abis_test.ok hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)