From: gitosis@osmocom.org Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Mon, 26 May 2014 06:19:52 GMT Message-ID: <201405260619.s4Q6Jqvo087901@git.osmocom.org> Subject: openbsc.git branch hfreyther/fixes/channel-release-handling updated. 0.13.0-396-g8270e04 Message: 6 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, hfreyther/fixes/channel-release-handling has been updated discards a934e5a2f99071b541fe76af108464d6ae6abb84 (commit) discards 4e986da48ac4219592e94bb758bbe2f69a664fa8 (commit) discards 637b08f417382a5aa2fc8a6343735204cfdf95ca (commit) discards 2c173fc14610ae4d8e24b5fc0fe651254a300eaa (commit) via 8270e04c3284b6301b57ac68845584b3bd6e7285 (commit) via d0ddfdadb548b162e55f2d5b07aa102bde994cec (commit) via 9cd66da0b3dbbfa273c2e5d922e7b8fd753ece9e (commit) via f6b61e61543959482731f2042584773b7fa0d7be (commit) via ee41ecff98379e38c2dcfb35c86ae8bd19c7b811 (commit) via 4f200491ff217e48ebc10f31e85386899b63dbd8 (commit) via 1cc5ff8e19c840545ae746c52995d0768c2d1f70 (commit) via f259bd8359de61e9c8aa92c775b95665c1a143d5 (commit) via cab6e7528c475d6aee687001a6146e5f20d8f53d (commit) via 038f97a69fe58d2bcb6cabcb82b3485f7d622ed2 (commit) via 45fcb852369a1acaa2c626e1a1063e9d1f042825 (commit) via a4c63b0cdba82a453875d9208d9dad0b9b530d56 (commit) via ec757986442e5be817caae4dacc57ec6617b98dd (commit) via a87f8f98918bc8f56f80ca7cc262b8edf5dcfadc (commit) via d8967f76a50e7639902ba50a01e938171b8ad18d (commit) via 72c0dbd7538aca983e1fde0ff36a292af77ab29a (commit) via a4d0e3cc6b07d4eebbf3ac08be1d296121c3f5ea (commit) via 20f6e946e13849ffb2d2a1d2a61dd00f7b8cdd11 (commit) via b66f158b050503a68468aa55ae6e7b7df92e3fb8 (commit) via 6e36255221d588f5de20b124748b589249ea825b (commit) via 1159005ae02f8c9e42624769ec1b2a8d84c9dee5 (commit) via 268b2e65446fef5c3ddb3bb4423ddf376929e731 (commit) via 47d8f02c068a8ea859630df4b4fd06792b4fd6ef (commit) via 543e11496e1499f0e2455d3d0d95a9f07e5135df (commit) via 10bad1031e8d45b3833abb42171d4a7527bca8f1 (commit) via b9f45987b3ca9e450e3b9ea2d009dfa127009dc7 (commit) via abddd6aa441b85d030f0f9c12ca326cf956063fb (commit) via 3c9068f185dd76d1051e58f1423b4ae612d12ee3 (commit) via f242e7afef5353c16e15e84437d54fcb26a24cb3 (commit) via edfdc9829cc2cc6f05a9cd9015e22210e442a259 (commit) via 6114401b9bce9322fb2826fe41393d03d0981ab2 (commit) via e7cc9aa44730b42bcbab0cf179ac66a9b25f04da (commit) via ca7ed2d2df55e8c1811d9dab13a2ada68ea1e9a3 (commit) via 73bc51deeab1eb38049614d67cd57f89275d7ad3 (commit) via ca3c256579a731b6b2bcea73478af1e0cadd1355 (commit) via 1b148ec1009c32faea269331836e366cfff7d18e (commit) via e9faa6f3a411e4fc7ff7968ee4be279b28296eec (commit) via 86decfb53ca4efff2548980e4bee7fd246198d93 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (a934e5a2f99071b541fe76af108464d6ae6abb84) \ N -- N -- N (8270e04c3284b6301b57ac68845584b3bd6e7285) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=8270e04c3284b6301b57ac68845584b3bd6e7285 commit 8270e04c3284b6301b57ac68845584b3bd6e7285 Author: Holger Hans Peter Freyther Date: Sat Apr 19 17:38:33 2014 +0200 rsl: Check if the channel is active and then start the channel release In case we receive ERROR INDICATION and CONNECTION FAILURE we only want to RF Channel Release the lchan once. This code is more simple and should work as reliable as the previous commit. http://cgit.osmocom.org/openbsc/commit/?id=d0ddfdadb548b162e55f2d5b07aa102bde994cec commit d0ddfdadb548b162e55f2d5b07aa102bde994cec Author: Holger Hans Peter Freyther Date: Sat Apr 19 16:45:36 2014 +0200 rsl: Avoid double channel release procedure in error conditions When we receive an ERROR INDICATION and CONNECTION FAILURE we might call rsl_rf_chan_release multiple times. The channel release handling is still a bit messy and there too many paths that lead to the call. 1.) In case we receive an ERROR INDICATION for SAPI=3. A RLL error signal will be emitted that leads to the release of the channel through the SMS code in case of the NITB. The call to rsl_rf_chan_release might be a double release. 2.) In case a CONNECTION FAILURE is received when the release process has already been started we would unconditionally call rsl_rf_chan_release as well. Because the lchan state is changed by the callers of the rsl_rf_chan_release we can not move the state checking into this code but need to do it in the caller. The issue was seen in a trace from Rhizomatica and I created the DoubleRelease.st to re-produce the issue and verified that we have no duplicate RF Channel Releses. The other option would be to introduce a new state to track the release process and see if we have already released SAPIs deactivated the SACCH or such. We can not simply look at these as for a channel that fails to activate they will be null already. http://cgit.osmocom.org/openbsc/commit/?id=9cd66da0b3dbbfa273c2e5d922e7b8fd753ece9e commit 9cd66da0b3dbbfa273c2e5d922e7b8fd753ece9e Author: Holger Hans Peter Freyther Date: Sun Apr 6 12:21:05 2014 +0200 lchan: Speculative "fix" for error and late reply Looking at the code it seemed possible that a channel would transition from BROKEN to NONE. Or worse from NONE to BROKEN. Start the timer _after_ the channel has been released. ----------------------------------------------------------------------- Summary of changes: debian/osmocom-gbproxy.init | 6 +- openbsc/configure.ac | 3 +- openbsc/contrib/rtp/gen_rtp_header.erl | 34 ++- openbsc/include/openbsc/Makefile.am | 3 +- openbsc/include/openbsc/bsc_msc.h | 2 + openbsc/include/openbsc/bsc_nat.h | 5 +- openbsc/include/openbsc/control_cmd.h | 46 ++-- openbsc/include/openbsc/gsm_data.h | 1 - openbsc/include/openbsc/gsm_data_shared.h | 1 + openbsc/include/openbsc/ipaccess.h | 1 - openbsc/include/openbsc/mgcp.h | 13 + openbsc/include/openbsc/mgcp_internal.h | 19 +- openbsc/include/openbsc/osmux.h | 19 ++ openbsc/src/ipaccess/ipaccess-find.c | 5 + openbsc/src/libbsc/abis_rsl.c | 2 +- openbsc/src/libbsc/bsc_ctrl_commands.c | 1 - openbsc/src/libbsc/bsc_ctrl_lookup.c | 14 +- openbsc/src/libbsc/chan_alloc.c | 5 + openbsc/src/libbsc/gsm_subscriber_base.c | 6 + openbsc/src/libctrl/control_cmd.c | 2 - openbsc/src/libmgcp/Makefile.am | 8 +- openbsc/src/libmgcp/mgcp_network.c | 50 ++-- openbsc/src/libmgcp/mgcp_protocol.c | 64 ++++- openbsc/src/libmgcp/mgcp_vty.c | 44 ++++ openbsc/src/libmgcp/osmux.c | 400 ++++++++++++++++++++++++++++++ openbsc/src/libmsc/db.c | 302 +++++++++++++++++----- openbsc/src/libmsc/gsm_04_08.c | 15 +- openbsc/src/libmsc/gsm_04_11.c | 9 +- openbsc/src/libmsc/smpp_openbsc.c | 5 +- openbsc/src/libtrau/rtp_proxy.c | 60 ++++- openbsc/src/osmo-bsc/osmo_bsc_ctrl.c | 38 +-- openbsc/src/osmo-bsc/osmo_bsc_msc.c | 2 +- openbsc/src/osmo-bsc_mgcp/Makefile.am | 3 +- openbsc/src/osmo-bsc_nat/Makefile.am | 5 +- openbsc/src/osmo-bsc_nat/bsc_mgcp_utils.c | 32 ++- openbsc/src/osmo-bsc_nat/bsc_nat.c | 2 +- openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 19 ++ openbsc/src/osmo-nitb/bsc_hack.c | 4 +- openbsc/tests/bsc-nat/Makefile.am | 4 +- openbsc/tests/bsc-nat/bsc_nat_test.c | 2 +- openbsc/tests/ctrl_test_runner.py | 43 ++++ openbsc/tests/db/Makefile.am | 2 +- openbsc/tests/db/db_test.c | 96 +++++++ openbsc/tests/db/db_test.err | 2 + openbsc/tests/db/hlr.sqlite3 | Bin 0 -> 29696 bytes openbsc/tests/mgcp/Makefile.am | 2 +- openbsc/tests/mgcp/mgcp_test.c | 1 + openbsc/tests/testsuite.at | 4 +- 48 files changed, 1193 insertions(+), 213 deletions(-) create mode 100644 openbsc/include/openbsc/osmux.h create mode 100644 openbsc/src/libmgcp/osmux.c create mode 100644 openbsc/tests/db/db_test.err create mode 100644 openbsc/tests/db/hlr.sqlite3 hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)