From: git repository hosting Precedence: list To: osmocom-commitlog@lists.osmocom.org Date: Sun, 23 Dec 2012 20:21:02 +0100 Message-ID: Subject: openbsc.git branch zecke/channel-release updated. 0.12.0-190-gb348939 Message: 3 This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, zecke/channel-release has been updated discards 02e71cd98a40e3dac4ac4a10dc80ff955a4c73dc (commit) discards b061c39d49332531b22fb8a03b7306bfe3a11ea2 (commit) discards f70d0d7328e297062a386761a363f39e7770e166 (commit) discards 987f0a59613d210608872db47d98988b37f1caa0 (commit) discards 82db74e0f83ef456fdd3a9f52d8a2514d82ba72c (commit) discards b71f5569d269f3fcc7888beeb0370e7b1201cb21 (commit) discards ffceee9d7c45ade1e1834a7e3166eed3404f151c (commit) discards 1d391186e3251625bd7fc266e226fb997f29c581 (commit) discards f907346eae7142dd0bd1040e592f3fcbb957d6b4 (commit) via b348939d86bbadab2b162dda00246abdfd33055a (commit) via 638da51a786c279cf7769afbb6fdb56cc4c6c867 (commit) via 9d50a27695fe512df2b429ecae93e66941a3f7e9 (commit) via 8582535c829e6a40591448e4b794af8fb022624e (commit) via 960c4044e61c8b4a522649c5d0e8f29b777356a6 (commit) via 93599a2c2c2a673ff3f19031850565050b4eb02c (commit) via d66777f9cfc5b74253b1b163e2d8dc32e8f50ef9 (commit) via 5ca825e431e837b95f7db9057792e5a66de97a89 (commit) via 1411c066cc3ddaa46437cac7c580a04a1fe95eb1 (commit) via 10049bc3b701a0e8ce1dc5242c7c683a8c0ca99b (commit) via 3e9b2ec257bc064b866ce6a2735206dc6131f615 (commit) via 405824c057d11843f29100124b38f9426101d8e8 (commit) via 25b70cea9d9521b081ea0cc524f5d157a1b89baf (commit) via 0e0a09c610885b0e4255eff9dfccc7b6b52854c2 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (02e71cd98a40e3dac4ac4a10dc80ff955a4c73dc) \ N -- N -- N (b348939d86bbadab2b162dda00246abdfd33055a) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/cgit/openbsc/commit/?id=b348939d86bbadab2b162dda00246abdfd33055a commit b348939d86bbadab2b162dda00246abdfd33055a Author: Holger Hans Peter Freyther Date: Wed Dec 28 16:21:05 2011 +0100 lchan: Introduce T3109 handling for the release procedure T3109 is started when the SACCH is deactivated. It is stopped when the phones sends the DISC/UA/UM on LAPDm for the main signalling link. In case of timeout the abnormal release procedure will be initiated. Make sure to not issue the SACCH Deactivate twice to avoid confusing the equipment. This is still not fully spec compliant. In case of a timeout the abnormal release handling will be started which involves starting T3111+2. The error handling should be split out of the rf channel release method, e.g. lchan_release should be called and check if the channel release was already initiated. http://cgit.osmocom.org/cgit/openbsc/commit/?id=638da51a786c279cf7769afbb6fdb56cc4c6c867 commit 638da51a786c279cf7769afbb6fdb56cc4c6c867 Author: Holger Hans Peter Freyther Date: Thu Dec 6 19:25:06 2012 +0100 lchan: Introduce a BROKEN state for the lchan If the CHAN ACTIV is NACKED we set the state backto NONE. This is problematic as our channel allocator will allocate from the front or from the back and if the channel is early in the list it might cause permanent failures. Introduce a BROKEN state and use it when the channel activation is failing for an unknown reason. Copy the cause so it can be inspected later. http://cgit.osmocom.org/cgit/openbsc/commit/?id=9d50a27695fe512df2b429ecae93e66941a3f7e9 commit 9d50a27695fe512df2b429ecae93e66941a3f7e9 Author: Holger Hans Peter Freyther Date: Wed Dec 28 12:11:40 2011 +0100 lchan: Document the behavior/quirks for abnormal channel release Deactivate the SACCH and release all SAPIs locally as of GSM 04.08. Add documentation to the code and explain what will happen as part of the release process. http://cgit.osmocom.org/cgit/openbsc/commit/?id=8582535c829e6a40591448e4b794af8fb022624e commit 8582535c829e6a40591448e4b794af8fb022624e Author: Holger Hans Peter Freyther Date: Tue Dec 27 22:24:17 2011 +0100 lchan: Release the lchan more quickly, align with GSM 04.08 * Release all channels with SAPI > 0 with the "local end release" (as of NOTE 1 of GSM 04.08). * No need to wait for all SAPIs to be torn down and the normal REL_IND/REL_CONF will call rsl_handle_release and the channel should be released. * Update the documentation http://cgit.osmocom.org/cgit/openbsc/commit/?id=960c4044e61c8b4a522649c5d0e8f29b777356a6 commit 960c4044e61c8b4a522649c5d0e8f29b777356a6 Author: Holger Hans Peter Freyther Date: Tue Dec 27 21:43:22 2011 +0100 lchan: Release all higher sapis on the local end. According to GSM 04.08 3.4.13.1.1 RR connection release in NOTE 1 one should release all non main signaling links using the local end link release. http://cgit.osmocom.org/cgit/openbsc/commit/?id=93599a2c2c2a673ff3f19031850565050b4eb02c commit 93599a2c2c2a673ff3f19031850565050b4eb02c Author: Holger Hans Peter Freyther Date: Thu Dec 6 19:09:58 2012 +0100 rsl: Cosmetic changes to the release code Put the idiom that sets the lchan state to none and respecting the error state into a shared method. This way the special handling for the abnormal case is just in one place. http://cgit.osmocom.org/cgit/openbsc/commit/?id=d66777f9cfc5b74253b1b163e2d8dc32e8f50ef9 commit d66777f9cfc5b74253b1b163e2d8dc32e8f50ef9 Author: Holger Hans Peter Freyther Date: Thu Dec 6 12:20:56 2012 +0100 rsl: Call the release function with the enum name and not the number Done with the semantic patch: @rule1@ expression E; expression F; @@ - lchan_release(E, F, 1); + lchan_release(E, F, RSL_REL_LOCAL_END); @rule2@ expression E; expression F; @@ - lchan_release(E, F, 0); + lchan_release(E, F, RSL_REL_NORMAL); http://cgit.osmocom.org/cgit/openbsc/commit/?id=5ca825e431e837b95f7db9057792e5a66de97a89 commit 5ca825e431e837b95f7db9057792e5a66de97a89 Author: Holger Hans Peter Freyther Date: Thu Dec 6 12:01:38 2012 +0100 rsl: Rename the reason to release_mode and use the enum value The API with 0 and 1 as legal values is hard to understand. Use the recently introduced enum values instead. http://cgit.osmocom.org/cgit/openbsc/commit/?id=1411c066cc3ddaa46437cac7c580a04a1fe95eb1 commit 1411c066cc3ddaa46437cac7c580a04a1fe95eb1 Author: Holger Hans Peter Freyther Date: Thu Dec 6 19:00:35 2012 +0100 rsl: Use LOGL_ERROR instead of LOGL_NOTICE act/deact timeouts It is a grave error when the BTS does not respond to the ACT/DEACT requests, use LOGL_ERROR for such conditions. ----------------------------------------------------------------------- Summary of changes: openbsc/configure.ac | 47 ++++++++++++---------------- openbsc/include/openbsc/gsm_data_shared.h | 4 ++ openbsc/src/libbsc/chan_alloc.c | 3 +- openbsc/src/libbsc/paging.c | 4 ++ openbsc/src/libmsc/gsm_04_08.c | 21 ++++++++++--- openbsc/src/libmsc/transaction.c | 4 ++- 6 files changed, 49 insertions(+), 34 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)