Hi Folks,

When I build OpenBsc, I find a number of cases where libosmovty isn’t in the link, but is needed by libosmoabis (basically anywhere libosmoabis is linked, but vty isn’t) e.g.

/bin/ld: warning: libosmovty.so.1, needed by /.build/usr/local/lib/libosmoabis.so, not found (try using -rpath or -rpath-link)

/.build/usr/local/lib/libosmoabis.so: undefined reference to `install_node'

/.build/usr/local/lib/libosmoabis.so: undefined reference to `install_element_ve'

/.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_out_rate_ctr_group'

/.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_out'

/.build/usr/local/lib/libosmoabis.so: undefined reference to `install_element'

/.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_install_default'

I’m not sure why/how I’m seeing this and others apparently aren’t, but it looks legitimate.  I’ve verified the configure script has [correctly] derived build configfrom the staged pkgconfig:

LIBOSMOABIS_CFLAGS='-I/.build/usr/local/include/  '

LIBOSMOABIS_LIBS='-L/.build/usr/local/lib -losmoabis  '

So I wonder if libosmoabis.pc.in should be updated to include vty, a bit like libosmogb.pc.in i.e.

Signed-off-by: Michael McTernan <Michael.McTernan@wavemobile.com>

--- libosmoabis.pc.in   (revision 19495)

+++ libosmoabis.pc.in   (working copy)

@@ -6,6 +6,6 @@

Name: A-bis Core Library

Description: C Utility Library

Version: @VERSION@

-Libs: -L${libdir} -losmoabis

+Libs: -L${libdir} -losmoabis -losmovty

Cflags: -I${includedir}/

Otherwise every user of libosmoabis has to remember to link with –losmovty as well.

Kind Regards,

Mike

PS: I’ve stripped the very long full build paths from output – I don’t really build in /.build!