Calculation looks correct. Have you tested it? IIRC I added tests for BER calculations which you could extend.

--
Regards,
Alexander Chemeris
CEO Fairwaves, Inc.
https://fairwaves.co


On Aug 4, 2016 19:18, "Max" <msuraev@sysmocom.de> wrote:
Please have a look at gerrit #623 - am I computing BER properly? I've
tried to follow what's done for meas. ind. Also, how would you recommend
to compute/estimate C/I? In the current patch version I'm just using 0.

On 08/02/2016 12:57 AM, Tom Tsou wrote:
> On Fri, Jul 29, 2016 at 5:18 PM, Alexander Chemeris
> <alexander.chemeris@gmail.com> wrote:
>> Burst timing is also passed from osmo-trx to osmo-bts, so should be trivial
>> to pass through.
> Yes. I don't know where the TOA value ends up in osmo-bts, but the
> value is definitely carried per-burst on the socket interface.
>
>> For C/I we need a comment from Thomas. Currently we don't have it on the
>> osmo-trx interface and I'm not even sure we calculate it.
> We don't have C/I directly. We do have a running average 'noise' level
> (calculated channel power on non-active uplink slots) and the RSSI
> value. The channel noise is queried with the NOISELEV command. RSSI is
> carried per-burst on the socket message. C/I can be calculated from
> those two values.
>
> Do we need a periodically averaged C/I value or an update every burst?
>
>   -TT

--
Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte