On Wed, Nov 25, 2015 at 3:31 PM, Holger Freyther <holger@freyther.de> wrote:

> On 25 Nov 2015, at 13:22, Holger Freyther <holger@freyther.de> wrote:
>
>
>
> Have you considered using SMPP for USSD? At first this looks more natural
> than a custom protocol like SUP.

The other part I notice when going through the patches are the following:

* Fixes, features without a unit test is very difficult to sell

I agree that having a unit test is a good sign. But I'm not really familiar with the project rules.

I can make unit tests for packet parsing/composing (SS and MAP-like level). But I have no idea how to make a unit test for e.g. USSD transaction based on gsm_trans or more complex things. I'd be glad to hear your thoughts.

* SUP has a protocol description. If the protocol is changed the description should
be updated.

I think I don't get this. Which protocol description are you talking about?

* If gprs sup client is used in non GPRS context we either split the protocol up or
at least rename and move these files around.

I intentionally left this part as is to get a feedback how it's possible solve. So you suggest to separate abstract socket operations away from GPRS, right?

If you have questions of any of the above points I am happy to answer them.

holger