Attention is currently required from: osmith, neels, fixeria.
Patch set 3:Code-Review -1
View Change
1 comment:
Patchset:
Patch Set #3:
I think I don't like the approach of only selectively decoding + storing some parts of the BSSMAP messages. This means the bsc-nat will drop any present or future optional IEs of the messages while it passes them through.
IMHO we should just parse/modify/re-encode those IEs we care about, but be transparent for any other IEs. We don't want to update (or forget to update) osmo-bsc every time we implement some new feature mailing use of those IEs.
To view, visit change 27712. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b
Gerrit-Change-Number: 27712
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Apr 2022 06:00:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment