Attention is currently required from: Hoernchen.
Patch set 7:Verified +1Code-Review +2
4 comments:
Patchset:
I have read through again and I couldn't spot any mistakes. I also have re-tested it by installing a java applet from pySim-shell with security level 3. Thanks for putting the spec references. Those helped me a lot with understanding the patch.
File pySim/global_platform/__init__.py:
Patch Set #7, Line 158: That legacy form is accepted when parsing, but never generated, which agrees with the spec"""
I have looked it up also. There is indeed a deviation from what we normally have in ASN.1 BER-TLV. This is the first time I hear about this indefinite form. I have never seen anything like that anywhere in the smartcard world. Its probably safe to say that it is not applicable to GP.
File pySim/global_platform/scp.py:
Patch Set #7, Line 252: # is formatted as described in Table 11-70: preceded by the actual length of the
In GlobalPlatform Card Specification 2.2.1, Table 11-70 is PUT KEY Error Conditions, in the Public Review v2.3.1.49 its Format of Key Component Block – Padding Present if Needed. So table references shift from version to version. Very distracting...
File tests/unittests/test_globalplatform.py:
Patch Set #7, Line 385: # GP CardSpec v2.3.1 Section 11.8.2.3.1: all lengths ofPUT KEY are always BER TLV coded
missing space ("...length ofPUT KEY...")
To view, visit change 43172. To unsubscribe, or for help writing mail filters, visit settings.