Attention is currently required from: neels, msuraev.

View Change

1 comment:

• File src/sua.c:

  • Patch Set #1, Line 184: /* ITU-T Rec Q.713 */

    this spec is about SCCP, not SUA?

    Background: SUA is a (much younger, IETF-provided) alternative protocol for (SCCP+MTP). As SUA functionality is a superset of SCCP (you can express everything possible in SCCP with SUA, but SUA has some additional bits you cannot express in SCCP) I decided that our stack internally uses SUA, and only transcodes to SCCP when SCCP is needed.

    The SUA spec often falls back on SCCP.

    I think it's useful to add these kind of annotations, but if one wants to do that, one should first mention the SUA RFC section and then the ITU-T reference, something like
    "RFC1234 section 3.4 resembling Q.714 Secion 4.2"
    or the like.

    However, given that the task at hand was not to improve the documentation of our SIGTRAN code but to implement a specific message size limit, I don't think it is worth investing time

To view, visit change 29158. To unsubscribe, or for help writing mail filters, visit settings.