Attention is currently required from: neels, fixeria, msuraev.
View Change
1 comment:
Patchset:
Patch Set #14:
It's more consistent with existing multiaddr API: we already have separate functions like osmo_sock_ […]
osmo_sock_init2_multiaddr was needed because the previous API didn't allow for passing such parameters, so it could not be reused.
I don't see why it is the case for this API.
If you reuse the same API the caller, usch as libosmo-netif patch you shared, doesn't need to care and we don't need to update it.
To view, visit change 28997. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521
Gerrit-Change-Number: 28997
Gerrit-PatchSet: 14
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: msuraev <msuraev@sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Oct 2022 18:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev@sysmocom.de>
Gerrit-MessageType: comment