Attention is currently required from: fixeria.
View Change
1 comment:
File src/core/context.c:
Patch Set #2, Line 33: osmo_ctx->select = talloc_named_const(OTC_GLOBAL, 0, "select");
I'd actually prefer leaving the variable names here, since it's really where they are set so it's far more clear to understand osmo_ctx->global and OTC_GLOBAL are actually the same.
To view, visit change 31914. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2aa03c7c68b7cca17eebbf858ada7c42f0d0a1da
Gerrit-Change-Number: 31914
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Mar 2023 15:02:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment