Attention is currently required from: laforge, neels.

Patch set 5:Code-Review +2

4 comments:

Patchset:
- Patch Set #5:
  I have now carefully looked at this. To my eyes, everything looks fine. I also thing that you have already tried that out somewhere.
File pySim/esim/saip/personalization.py:
- Patch Set #5, Line 129: for pe in pes.get_pes_for_type('usim'):
  I am not 100% sure here, maybe our application does not even require this. But in "eUICC Profile Package: Interoperable Format Technical Specification" I see that the ED.SMSP not only appears in USIM, it appears in ISIM and CSIM as well, but as optional files.
- Patch Set #5, Line 131: f_smsp = pe.files['ef-smsp']
  This should be ok, in "eUICC Profile Package: Interoperable Format Technical Specification", section 9.5.1 I can see that EF.SMSP is on the list with the mandatory files, so it should be always there.
- Patch Set #5, Line 132: #print("SMSP (orig): %s" % f_smsp.body)
  Do you want to keep this commented out debug print? (there is another one below)

To view, visit change 41735. To unsubscribe, or for help writing mail filters, visit settings.