Attention is currently required from: laforge, osmith.

View Change

3 comments:

• File rebar.config:

  • Patch Set #3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib", {branch, "osmocom/master"}}},

    wouldn't it be better to use an exact commit instead? that way it would be clear from git history wh […]

    This information is kept in rebar.lock. For now it's good keeping it like this while we are doing active development.

• File rebar.lock:

  • Patch Set #3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}},

    * unrelated change […]

    Because it's rebar.lock and not rebar.config.
    If rebar.lock exists (it is generated upon built if doesn't exist), then during checkout the values in that file are used.
    If no rebar.lock exists, then the values from rebar.config are used.

    I intended to merge this change here too, since osmo_gsup was updated to also accomodate new changes required (osmo_gsup HEAD of the rebar.config branch changed).

  • Patch Set #3, Line 37: {git,"https://github.com/uwiger/parse_trans.git",

    unrelated change (unlike gitlab, there is no git redirect if using github urls without . […]

    This appeared automatically when updating gtplib. It's newer gtplib pulling this in afaict.

To view, visit change 36052. To unsubscribe, or for help writing mail filters, visit settings.