Attention is currently required from: laforge, pespin.
View Change
1 comment:
Patchset:
Patch Set #1:
I agree with Harald. Not sure if adding this one will make us shoot on our own foot.
Ok. Any ideas how to improve?
I dislike initializing llist "entries" by pointing it to itself. This should be only done for llist "heads".
What is the correct value for an llist "entry" which isn't part of a queue?
Should it be NULL? Should it be POISON1/2? Should it be something else?
To view, visit change 29792. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia4afe3e77f53728db1d139bded5925183dca011f
Gerrit-Change-Number: 29792
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Oct 2022 20:35:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment