Attention is currently required from: dexter.

View Change

1 comment:

• File src/gprs_rlcmac_sched.cpp:

  • Patch Set #2, Line 492: skip_idle = skip_idle && trx != 0;

    I think now that we don't have the #ifdef, we can really simplify this to:

        bool skip_dummy;
        if (bts->gen_dummy_blk) {
           skip_dummy = false;
        } else {
         const unsigned num_tbfs = pdch->num_tbfs(GPRS_RLCMAC_DL_TBF)
    	    				+ pdch->num_tbfs(GPRS_RLCMAC_UL_TBF);
         skip_dummy = (num_tbfs == 0);
        }

    This can again be simplified to:

        bool skip_dummy = bts->gen_dummy_blk;
        if (skip_dummy) {
         /* Only skip if no one is listening on this PDCH: */
          const unsigned num_tbfs = pdch->num_tbfs(GPRS_RLCMAC_DL_TBF)
    	    				+ pdch->num_tbfs(GPRS_RLCMAC_UL_TBF);
         skip_dummy = (num_tbfs == 0);
        }

To view, visit change 35096. To unsubscribe, or for help writing mail filters, visit settings.