Attention is currently required from: arehbein.
View Change
1 comment:
Patchset:
Patch Set #1:
osmo_iofd_init() is only called from the main thread, it needs to be public similar to osmo_select_init() to initialize TLS in a multithreaded program.
See osmo-remsim/src/client/user_ifdhandler.c where osmo_select_init() is called explicitly. I'd suggest to only fix the declaration in the header to match the function name.
To view, visit change 34524. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I77f7ae2b211507f420d87c484ec75ee054fceb63
Gerrit-Change-Number: 34524
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: arehbein <arehbein@sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Sep 2023 20:54:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment