Attention is currently required from: laforge, msuraev.

Patch set 2:Code-Review -1

4 comments:

File examples/sccp_test_vty.c:
- Patch Set #1, Line 97:
  unrelated cosmetic change to the indent level. […]
  I would expect it to be aligned to the opening brace, and it looks like you intended to do so. It might be that you're using non-standard tab-size=4, while in C projects it's 8. Please either undo this change, or properly align to the opening brace.
File examples/sccp_test_vty.c:
- Patch Set #2, Line 97: [DATA]
  You forgot to add documentation an optional parameter:
```
  # disconnect-req?
    disconnect-req    N-DISCONNT.req
  # disconnect-req ?
    <0-16777216>      Connection ID
  # disconnect-req 0 ?
    [DATA]            NULL <!-----------------------
```
- Patch Set #2, Line 103: argv[1]
  Is argv[1] guaranteed to be NULL if argc < 2? There might be garbage left in the argv[] buffer, so I would rather rely on argc:
```
  const uint8_t *data = NULL;
```
```
  if (argc > 1)
    data = (const uint8_t *)argv[1];
```
  Also, wouldn't it be more useful to accept a hex-string as the input?
File include/osmocom/sigtran/sccp_helpers.h:
- Patch Set #2, Line 48:
  Really weird alignment making it rather harder to read. Tab-size should be 8.

To view, visit change 29170. To unsubscribe, or for help writing mail filters, visit settings.