Attention is currently required from: daniel, laforge, pespin.

View Change

1 comment:

• File src/core/gsmtap_util.c:

  • Patch Set #2, Line 52: struct osmo_wqueue wq; /*!< the wait queue */

    This is fine because it keeps the same offset. […]

    How about also adding the same struct decl. with another tag, e.g. `struct gsmtap_inst_legacy` (same members etc.), to fix the old struct and then add `OSMO_ASSERT(offsetof(struct gsmtap_inst_legacy, wq) == offsetof(struct gsmtap_inst, wq))` when running `gsmtap_source_init*()`?

To view, visit change 34720. To unsubscribe, or for help writing mail filters, visit settings.