Attention is currently required from: fixeria, laforge.

View Change

2 comments:

• File pySim-shell.py:

  • Patch Set #3, Line 868: verify_chv_parser.add_argument('PIN', nargs='?', type=is_decimal,

    Why are you moving positional arguments before the optional `--pin-nr`? It's not critical, but makes […]

    Its the same with verify ADM. I have changed it so that it is consistent with verify_adm. I guess this means I have to go through all parser definitions to see if it is wrong elsewhere.

  • Patch Set #3, Line 902: change_chv_parser.add_argument('NEWPIN', nargs='?', type=is_decimal,

    You're breaking compatibility by changing the ordering here: currently it's `OLD NEW`, but your patc […]

    This is intentional. Since we no longer use the placeholders, we must put NEW as first positional parameter so that we can leave OLD out to in case we want to get OLD from the CardKeyProvider.

To view, visit change 37838. To unsubscribe, or for help writing mail filters, visit settings.