Attention is currently required from: pespin, fixeria, daniel.
View Change
1 comment:
Patchset:
Patch Set #19:
So I changed the local port for the stream test from 8967 (previously used) to 8977 and the test ran […]
I just tried
```
log_set_print_timestamp(osmo_stderr_target, 0);
```
in `tests/stream/stream_test.c`
and got an immediate segfault (glanced at the code and I guess it's because the logging system isn't initialized by the test, it just uses `osmo_gettimeofday()` and custom macros for logging).
I could remove all the time logging instead from the macros defined in the test code. If that's what we want.
To view, visit change 33198. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I822abf52c6ae396c90b5c50228a0a39c848d3de6
Gerrit-Change-Number: 33198
Gerrit-PatchSet: 19
Gerrit-Owner: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: daniel <dwillmann@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Fri, 25 Aug 2023 16:02:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann@sysmocom.de>
Gerrit-MessageType: comment