Attention is currently required from: pespin.
pespin uploaded patch set #2 to this change.
osmux: Fix osmux seqnum incremented globally instead of per circuit
There's no real use in having a global seqnum. The seqnum, as specified
by the osmux protocol specification, relates to that of the RTP
seq+timestamp, hence it is per circuit.
Having it per circuit allows detecting gaps and lost batches on the
receiver side, applying the Marker bit on the re-assembled RTP packets.
As a resut of the fix, tests/osmux/osmux_test part validating Marker bit
started failing. It failed because it was wrongly written to start with,
since it used only one osmux_out_handle for the 4 CIDs in use, which was
wrong, since each CID must have its own osmux_out_handle as state is
kept there per circuit.
Related: SYS#5987
Change-Id: I562de6a871d8a35475c314ca107c2a12b55d6683
---
M src/osmux.c
M tests/osmux/osmux_test.c
M tests/osmux/osmux_test.ok
3 files changed, 589 insertions(+), 587 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/18/29518/2
To view, visit change 29518. To unsubscribe, or for help writing mail filters, visit settings.