Attention is currently required from: laforge.

View Change

1 comment:

• File pySim/filesystem.py:

  • Patch Set #2, Line 1338:

       def _decode_bin(self, raw_bin_data: bytearray):
            chunks = [raw_bin_data[i:i+self.rec_len]
                      for i in range(0, len(raw_bin_data), self.rec_len)]
            return [self.decode_record_bin(x) for x in chunks]
    
        def _encode_bin(self, abstract_data) -> bytes:
            chunks = [self.encode_record_bin(x) for x in abstract_data]
            # FIXME: pad to file size
            return b''.join(chunks)
    

    you are not passing the total_len as argument to the self.{encode,decode}_record_bin here. […]

    Thanks for the explaination, I think I got my head around this now.

    I have now revisited the code and have added a total_len parameter to the _encode_bin and _encode_hex methods. I also thing that we should also have total_len parameters on the _encode_record_hex and _encode_record_bin methods, in case someone needs the total_len parameter in one of those custom methods.

    All derived classes with custom encoder methods should now accept a total_len parameters. I have put a kwargs on each method that does not use the total_len parameter. I have seen that _encode_record_bin/hex have kwargs as well, so I think that makes sense.

To view, visit change 38195. To unsubscribe, or for help writing mail filters, visit settings.