Attention is currently required from: pespin.

View Change

2 comments:

• File src/common/vty.c:

  • Patch Set #5, Line 434: if (bts->use_twrtp != g_use_twrtp_default) {

    tbh, I see no need for the global variable here. […]

    I know full well that the approach you describe is the standard way used everywhere else. However, the present case is special:

    • We already plan from the get-go to change this default in the not too distant future. With my implementation only one line of code will need to change at that point, as opposed to having to remember to rework the vty write-out code for the opposite construct.
    • I plan on a follow-up patch that will introduce `--disable-ortp` configure option, and I hope we both agree that patch should be merge-able well before we reach the point of making twrtp the new default for everyone. Therefore, there will be a period of time when the default is still ortp in the standard build, but the special build with ortp disabled has to default to twrtp as it is the only supported selection. My global variable implementation is already prepared for this eventuality.

  • Patch Set #5, Line 1529: vty_out(vty,

    I'd say simply add here: […]

    Considering our already set plan to change the default at some point in the not too distant future, I really feel that both the current setting and the default should be displayed. It is important to know the default in this case, so that the operator can tell which library will be selected with a config file that does not specify `rtp library`.

To view, visit change 42167. To unsubscribe, or for help writing mail filters, visit settings.