Attention is currently required from: falconia, neels.

2 comments:

File src/trau/trau_rtp_conv.c:
- Patch Set #1, Line 282:
```
} else if (data_len == 0) {
		/* C1 .. C5: idle speech */
		tf->c_bits[0] = 0;
		tf->c_bits[1] = 1;
		tf->c_bits[2] = 1;
		tf->c_bits[3] = 1;
		tf->c_bits[4] = 0;
```
  Please read the rules of TS 48.060, particularly sections 6.5.2 and 6.5.3. […]
  I agree with your respons to neels' comment and I do know that the DL/UL are treated separtely. My objection was realted to the somewhat hard to follow control-flow where we have if (UL) {} else if {} (len ==0) else {}. It woul be better to split that up into a
```
if (UL) {
} else { /* DL*/ 
  if (len == 0) {
  } else {
  }
}
```
  so basically checking one thing per if/else, and not mixing two different things in one level. Alternatives would also be to use a switch statement for the UL/DL case. But in any case, don't mix the length check in the UL/DL decision.
- Patch Set #1, Line 441: if (data_len == 0 && tf->dir == OSMO_TRAU_DIR_DL) {
  In the present case (EFR codec) the answer to the "why" question is straightforward: because TS 48. […]
  Done

To view, visit change 32078. To unsubscribe, or for help writing mail filters, visit settings.