Attention is currently required from: jolly.

Patch set 8:Code-Review +1

View Change

4 comments:

• File include/osmocom/isdn/lapd_core.h:

  • Patch Set #8, Line 88: #define LAPD_F_RTS 0x0001

    (an enum would be nicer IMHO)

• File src/isdn/lapd_core.c:

  • Patch Set #8, Line 220: Function to

    (just drop the words "Function to", rationale: it is obvious that it is a function)

  • Patch Set #8, Line 400: \ref

    '\ref' is not valid doxygen here, see https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_API_documentation#Parameters

  • Patch Set #8, Line 1785: Function call when a LAPD frame is ready to sent.

    this is hard to understand, could you make this an "imperative form" description of what the function does, like

      Send the next LAPD frame.

    (if that is correct). That is the shortest and clearest form of doc. thanks

To view, visit change 34985. To unsubscribe, or for help writing mail filters, visit settings.