Attention is currently required from: laforge.

View Change

2 comments:

• File sysmoOCTSIM/hpl/core/hpl_init.c:

  • Patch Set #1, Line 57:

    // _osc32kctrl_init_sources();
    	// _oscctrl_init_sources();
    	// _mclk_init();
    // #if _GCLK_INIT_1ST
    // 	_gclk_init_generators_by_fref(_GCLK_INIT_1ST);
    // #endif
    // 	_oscctrl_init_referenced_generators();
    

    why are we just commenting this out rather than removing it?

    Because this serves as a reminder what must be done to run the fw without a bl + allows conveniently enabling all that for debbuging by uncommenting it. This is my change for me that allows me to semi-efficiently deal with debugging, it's not supposed to look nice.

• File sysmoOCTSIM/main.c:

  • Patch Set #1, Line 579: if(delayed_usb_reset)

    I'm wondering why we suddenly format "if" as if it was a function. […]

    the format issues happened during cleanup and merging of a dozen different branches with code in seperate files that had other formatting and was #included which prevented proper autoformat.

To view, visit change 39445. To unsubscribe, or for help writing mail filters, visit settings.