Attention is currently required from: pespin.

View Change

1 comment:

• File lint/lint_all.sh:

  • Patch Set #1, Line 19: echo "" | "$SCRIPT_DIR"/checkpatch/checkpatch.pl \

    why is this echo needed now?

    The other script `lint/lint_diff.sh` passes `git diff -U0 $COMMIT` on stdin to `checkpatch_osmo.sh`. This needs to be stored in a temp file and sent to each instance of `checkpatch` now that we potentially run it multiple times. I've implemented this with:

    ```
    # This script gets called with stdin set to a git diff or empty string. Put it
    # into a temp file so we can pass it along to checkpatch multiple times.
    cat >"$STDIN_TEMP"
    ```

    The `echo ""` is needed so the script doesn't stop at this `cat` line.

To view, visit change 42215. To unsubscribe, or for help writing mail filters, visit settings.