Attention is currently required from: neels, pespin, dexter.

View Change

1 comment:

• File src/bts.cpp:

  • Patch Set #17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));

    I like the idea of supporting both 0x0a and 0x0b in osmo-pcu, that's great. […]

    If we go this way (backwards compatibility), we would have to keep both `PCU_IF_MSG_DATA_CNF` and `PCU_IF_MSG_DATA_CNF_DT` as well as both `PCU_IF_SAPI_PCH` and `PCU_IF_SAPI_{AGCH->PCH}_DT` in the protocol definition. There would still be two ways of doing the same thing (sending data over PCH), what renders the idea of bumping the PCUIF version equal to having a flag in the `INFO.ind`. "Here we go again".

    We could use this version bump chance to clean up the protocol a bit and make life easier for those who will be working on the PCUIF in the future and trying to understand what message does what.

    I don't really want to block getting this work merged, and will better stop adding even more comments/nitpicks. But I really don't see the benefits of making version 0x0b backwards compatible with 0x0a, given that the patch for osmo-bts is already in Gerrit and upgrading osmo-bsc to 0x0b is not going to take too much effort either...

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.