Attention is currently required from: jolly.

View Change

2 comments:

• File src/ipa/libipa/proc_euicc_data_req.c:

  • Patch Set #1, Line 211:

    I think at this point it is too late to set the eimTransactionId. You have to do this before the ipa_esipa_prvde_eim_pkg_rslt() call. Otherwise there will be no effect. (as it seems the if/else statement below was intended for producing log messages only)

  • Patch Set #1, Line 216: IPA_LOGP(SIPA, LINFO, "IPA get EUICC data succeeded!\n");

    When looking closer I can see that this code is a bit misleading. At the moment we do not generate an ipaEuiccDataResponseError. If one of those ES10b function calls above fails, there will just be no result for this tag. Maybe this is something we should address. (create a ticket?)

To view, visit change 43035. To unsubscribe, or for help writing mail filters, visit settings.