Attention is currently required from: neels, dexter.

View Change

4 comments:

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #2, Line 802: ts->fi->state == TS_ST_PDCH

    Could you clarify why checking the FSM state is necessary? It's a bit weird to see code checking `fi->state` before sending an event. The FSM itself should take care of handling events in different states.

  • Patch Set #2, Line 935: struct gsm_bts_trx_ts *ts;

    This variable should be moved to the inner for-loop.

  • Patch Set #2, Line 973: gsm_bts_trx_num

    As I already commented on one of your previous patches, using `gsm_bts_trx_num()` in a loop is not a good idea. Better iterate over the `&bts->trx_list` directly, like you did in `pcu_tx_e1_ccu_ind()`.

  • Patch Set #2, Line 976: 8

    ARRAY_SIZE(trx->ts)

To view, visit change 31497. To unsubscribe, or for help writing mail filters, visit settings.