View Change

8 comments:

• File src/iu_helpers.c:

  • Patch Set #3, Line 134: switch (addr->u.sin.sin_family) {

    you should better use u.sa here conceptually, since you don't really know whether it's AF_INET (u.sin) or not. In practice it doesn't matter since it ends up in same memory position.

  • Patch Set #3, Line 140: ip_len = sizeof(addr->u.sin6.sin6_addr.s6_addr);

    Not sure if this is correct or needs to be sizeof(addr->u.sin6.sin6_addr) or it doesn't matter.

  • Patch Set #3, Line 148: len = 160 / 8;

    can you explain/document these numbers?

  • Patch Set #3, Line 183: binding_id[0] = port & 0xff;

    probably osmo_store16be() would be more clear here.

  • Patch Set #3, Line 187: new_transp_layer_addr(&tli->transportLayerAddress, addr, use_x213_nsap);

    check return code an return NULL

  • Patch Set #3, Line 201: new_transp_layer_addr(&tli->transportLayerAddress, addr, use_x213_nsap);

    check return code an return NULL

• File src/ranap_msg_factory.c:

  • Patch Set #3, Line 753: rtp_addr.u.sin.sin_addr.s_addr = htonl(rtp_ip);

    are you sure the rtp_ip is passed above in host byte order? looks weird to me.

  • Patch Set #3, Line 826: gtp_addr.u.sin.sin_addr.s_addr = htonl(gtp_ip);

    same

To view, visit change 26722. To unsubscribe, or for help writing mail filters, visit settings.