Attention is currently required from: laforge.
View Change
1 comment:
File src/osmo_ss7_asp.c:
Patch Set #2, Line 990: asp->asp_id = rand() & 0xf;
asp_id is used in the SCTP/M3UA case. It is not used in the IPA/TCP case at all.
I see you are "using" it here. So iiuc you mean you are actually storing this rand value here because this field is not really used for other stuff?
To view, visit change 36115. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ia4e66d660b6057338f66a47fffc8a0d32759f733
Gerrit-Change-Number: 36115
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Wed, 28 Feb 2024 20:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment