Attention is currently required from: jolly.

Patch set 3:Code-Review +1

View Change

1 comment:

• File bts/BTS_Tests_ASCI.ttcn:

  • Patch Set #3, Line 158:

    RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), uplink_free));
    	for (var integer i := 0; i < 20; i := i + 1) {
    		f_l1_exp_lapdm(tr_LAPDm_Bter_UI(uplink_free));
    		log("Received UPLINK FREE.");
    	}
    
    	/* Send one UPLINK BUSY message and expect it to be received. */
    	log("Send UPLINK BUSY.");
    	RSL.send(ts_RSL_UNITDATA_REQ(g_chan_nr, ts_RslLinkID_DCCH(0), uplink_busy));
    	f_l1_exp_lapdm(tr_LAPDm_UI(0, cr_MT_CMD, uplink_busy));
    

    again here I smell the potential for race conditions. […]

    nevermind. this is unit-data and there are no re-transmissions at BTS level, so this should be safe here.

To view, visit change 33817. To unsubscribe, or for help writing mail filters, visit settings.