Attention is currently required from: fixeria, laforge, pespin.
View Change
1 comment:
Patchset:
Patch Set #4:
I think you have a point here. […]
..but just hoping people don't just use HAVE_XX and don't include config.h is not really a fix either? The FW build can check if the logging is defined, btw, and if it is, break. Or we could enforce including config.h everywhere by adding a check...
See https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42208
To view, visit change 42205. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Feb 2026 19:27:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>