osmith has uploaded this change for review.

View Change

ipa: fix a minor memleak when receiving invalid IPA CCM messages

Change-Id: I1b828c16350d10398810e60acbb35663f215c63f
(cherry picked from commit e17a1fca7aa13a52a8b05fe249c8ee4f25bdf422)
---
M src/ipa.c
1 file changed, 3 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/52/41352/1

diff --git a/src/ipa.c b/src/ipa.c
index 6ca5b50..11b8b04 100644
--- a/src/ipa.c
+++ b/src/ipa.c
@@ -112,6 +112,7 @@
 static int ipa_rx_msg_ccm(struct osmo_ss7_asp *asp, struct msgb *msg)
 {
 	uint8_t msg_type = msg->l2h[0];
+	int rc = 0;
 
 	LOGPASP(asp, DLSS7, LOGL_DEBUG, "%s:%s\n", __func__, msgb_hexdump(msg));
 
@@ -135,12 +136,12 @@
 	default:
 		LOGPASP(asp, DLSS7, LOGL_NOTICE, "Unknown CCM Message 0x%02x: %s\n",
 			msg_type, msgb_hexdump(msg));
-		return -1;
+		rc = -1;
 	}
 
 	msgb_free(msg);
 
-	return 0;
+	return rc;
 }
 
 struct osmo_ss7_as *ipa_find_as_for_asp(struct osmo_ss7_asp *asp)

To view, visit change 41352. To unsubscribe, or for help writing mail filters, visit settings.