Attention is currently required from: jolly, laforge, pespin.

Patch set 2:Code-Review -1

View Change

8 comments:

• Patchset:

  • Patch Set #2:

    CR-1 due to missing `PRESENCE` attributes.

• File library/GSM_RR_Types.ttcn:

  • Patch Set #2, Line 590: HEX1

    Below in `UplinkAccessIndTV` you're using `uint4_t`. Maybe use it here too or use HEX1 everywhere for the sake of consistency?

  • Patch Set #2, Line 597: } with { variant "TAG(cksn, tag = 'B'H)" };

    doesn't this belong in line 592?

    No, it's correct. This reads as: the optional `cksn` TV field is present if the `tag` field within this field is equal to 'B'H. Alternatively, you could have defined this as follows:

    ```
    type record CipheringKeySeqNrTV {
    	HEX1			tag,
    	CipheringKeySeqNr	cksn
    } with { variant "PRESENCE(tag = 'B'H)" };
    ```

    I find this a bit more readable and less confusing.

  • Patch Set #2, Line 650: } with { variant (len) "LENGTHTO(es,spare,uai_rach,priority)" };

    Please add `variant "PRESENCE(iei = '31'O)"`.

  • Patch Set #2, Line 656: } with { variant "" };

    Missing `variant "PRESENCE(iei = '32'O)"`.

  • Patch Set #2, Line 663: } with { variant (len) "LENGTHTO(talker_id)" };

    Missing `variant "PRESENCE(iei = '33'O)"`.

  • Patch Set #2, Line 670: } with { variant "" };

    Missing `variant "PRESENCE(iei = 8)"`.

  • Patch Set #2, Line 690:

    ws

To view, visit change 32647. To unsubscribe, or for help writing mail filters, visit settings.