Attention is currently required from: neels, pespin.
Patch set 1:Code-Review +2
View Change
1 comment:
File src/vty/fsm_vty.c:
Patch Set #1, Line 196: return CMD_SUCCESS;
As an improvement, you could also maybe make a box for each event type, and then have an arrow from […]
I consider doing this incrementally, in a separate patch. For now I am afraid this would make the resulting graph more convoluted and harder to read, especially for FSMs with many states.
To view, visit change 36713. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I09ee0a8c3fc4b1aa991ab5c93c0b654fccd7ea4c
Gerrit-Change-Number: 36713
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Thu, 09 May 2024 08:45:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment