Attention is currently required from: laforge, pespin, dexter.

View Change

3 comments:

• File include/osmo-bts/bts.h:

  • Patch Set #1, Line 303: bool emit_hr_rfc5993;

    maybe an enum specific type would be better here, but not sure if such an enum exists already.

    There is no existing enum. If such enum did already exist, I would certainly use it, but do we really need to go to the trouble of creating one just for this purpose?

• File src/common/l1sap.c:

  • Patch Set #1, Line 1705: send_rtp_rfc5993(lchan, fn, msg->data, msg->len);

    agreed. Let's be smart in msgb usage rathe than andding memcpy/memmove/...

    Good point. I shall investigate to make sure that the necessary headroom does exist, and then make the change.

• File src/common/vty.c:

  • Patch Set #1, Line 802: DEFUN(cfg_bts_rtp_hr_format,

    As far as I can see the bts->emit_hr_rfc5993 is checked on every l1sap_tch_ind. […]

    Point taken - I shall look into doing what you suggest.

To view, visit change 32970. To unsubscribe, or for help writing mail filters, visit settings.