Attention is currently required from: neels, fixeria, msuraev.
View Change
2 comments:
File src/sccp_scoc.c:
Patch Set #15, Line 600: if (
in whihc situation would we have a zero-length opt_data_cache?
Patch Set #15, Line 639: msgb_alloc(SCCP_MAX_DATA, "SCCP optional data cache for CR/CC/RLSD");
If we ever should run into memory leaks, it would be better to use msgb_alloc_c(conn) to attach this msgb to the 'conn'.
To view, visit change 29084. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a
Gerrit-Change-Number: 29084
Gerrit-PatchSet: 15
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: msuraev <msuraev@sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Aug 2022 15:03:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment