Attention is currently required from: pespin.

View Change

1 comment:

• File src/osmo-bsc/gsm_data.c:

  • Patch Set #1, Line 192: { GSM_PCHAN_OSMO_DYN, "OSMODYN" },

    We use "OSMO_DYN", see line 209.

    not in the 'ts' / 'phys_chan_config' command we don't! see bts_trx_vty_init().

    oh, are you saying I should rather name it "OSMO_DYN"? I think that would be wrong, because in the phys_chan_config command, the underscore serves as a separator. Like "TCH/F_PDCH" is either "TCH/F" or "PDCH". "OSMO_DYN" would look like it is a pchan offering one of "OSMO" or "DYN".

    (the "+" separator is about pchans that offer multiple things at the same time, the "_" is for alternative modes)

    But I'm a bit puzzled, where do we use gsm_pchan_ids[] then?
    ... we only use it in timeslot_fsm.c, lchan_fsm.c, assignment_fsm.c. It is the CTRL-interface id compatible name for gsm_pchant_names. I guess we want to remove gsm_pchan_ids[], rather use gsm_pchant_names[] and use osmo_fsm_inst_update_id_f_sanitize() there? I'll see in a separate patch.

    This confusion makes me notice that this patch should have a vty test to go with it.

To view, visit change 31615. To unsubscribe, or for help writing mail filters, visit settings.