Attention is currently required from: jolly.

View Change

1 comment:

• File src/ipa/libipa/ipad.c:

  • Patch Set #1, Line 388: IPA_LOGP(SIPA, LERROR, "Unable to emulate retrieval of connectivity patameters.\n");

    When I was developing this emulation one of my principles was to move the compatibility logic as far away from the higher layers as possible.

    I think it is better to put this logic into ipa_es10b_get_conn_params() and return an a normal result with ConnectivityParametersError and undefinedError(127) as error code. You can log the error from inside ipa_es10b_get_conn_params then.

    However, if you implement it as suggested you cannot return -ENOSUP anymore because you do not know if it is the emulation that returns the error or if it is a real IoT euicc with a real problem. I still would opt for moving the logic into the function as it provides better layer separation.

To view, visit change 43054. To unsubscribe, or for help writing mail filters, visit settings.