Attention is currently required from: pespin.

View Change

3 comments:

• File library/RTP_Emulation.ttcn:

  • Patch Set #4, Line 364: private function f_check_fixed_rx_payloads(octetstring rtp_data, INT7b rtp_payload_type) runs on RTP_Emulation_CT {

    it feels a bit strange having the rtp_Data before the rtp_payload_type, but not criticial.

    Done

  • Patch Set #4, Line 376: if (rtp_data == g_cfg.rx_payloads[i].fixed_payload and rtp_payload_type == g_cfg.rx_payloads[i].payload_type) {

    split into 2 lines?

    Done

  • Patch Set #4, Line 388: if (payload_present and payload_error) {

    This function implementation seem overcmplex with all those bool vars. […]

    Since we now have to match multiple payload type numbers with multiple optional defined payloads the matching got more complicated. I have now revisited this function and added comments so now it is hopefully better to understand.

To view, visit change 32153. To unsubscribe, or for help writing mail filters, visit settings.