Attention is currently required from: laforge, pespin.
Patch set 8:Code-Review +1
View Change
1 comment:
File src/ipa.c:
Patch Set #3, Line 50: #i
I tend to agree, but given that the previous state was already quite caothic with files already name […]
I'm not sure I understand the argument. Why not name the new file ss7_asp_internal.h instead? I think that would make sense even if we already have other internal header files without _internal suffix.
I'd slightly prefer that, otherwise LGTM.
To view, visit change 38645. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I5839b4dd04468af20d1836386dcc722e7a83ac5f
Gerrit-Change-Number: 38645
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Nov 2024 14:47:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>