Attention is currently required from: laforge, pespin.

View Change

1 comment:

• File src/host/trxcon/src/sched_trx.c:

  • Patch Set #3, Line 167: .cfg = *cfg,

    This is probably wrong now. […]

    The lifetime of trxcon_inst is limited by the lifetime of l1sched_state, they cannot exist independently one without the other, so use-after-free is not a problem here. I intentionally want a pointer to trxcon->log_prefix, not a copy of it, because this would allow me to change trxcon->log_prefix on trxcon_fsm state change to reflect the current state in logging.

To view, visit change 28744. To unsubscribe, or for help writing mail filters, visit settings.