Attention is currently required from: daniel.

View Change

2 comments:

• File gtp/gtp.h:

  • Patch Set #2, Line 106: #define GTPCAUSE_129 129 /* For future use 129-176 */

    You broke the API compat here.
    If we deem these not necessary, then simply leave the comment and remove the defines, so that we don't keep updating (removing and adding) them.

  • Patch Set #2, Line 142: static inline bool gtp_cause_successful(uint8_t cause)

    not sure this is really useful to have here, I'd would have left it for the specific app. In any case one usually wants to check the exact cause in order to act differently here AFAIR.

To view, visit change 35084. To unsubscribe, or for help writing mail filters, visit settings.